Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect structured comments about return value of readMem and readMemUnchecked #13436

Open
BlocksOnAChain opened this issue Dec 17, 2024 · 0 comments
Open

Incorrect structured comments about return value of readMem and readMemUnchecked #13436

BlocksOnAChain opened this issue Dec 17, 2024 · 0 comments
Labels
MT cannon - audit findings grouping for audit findings MT cannon - Mainnet relevant issues needed to complete the work for our Mainnet release

Comments

@BlocksOnAChain
Copy link

As per Spearbit audit findings:

Description:
The comments at MIPS64Memory.sol:13 and MIPS64Memory.sol:28 both read @return out_ The hashed MIPS state. - while they should read @return out_ The read memory word.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
MT cannon - audit findings grouping for audit findings MT cannon - Mainnet relevant issues needed to complete the work for our Mainnet release
Projects
Proofs team - Project Delivery tracking board
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BlocksOnAChain