Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment says 4 bytes, but it is actually the word size #13435

Open
BlocksOnAChain opened this issue Dec 17, 2024 · 0 comments
Open

Comment says 4 bytes, but it is actually the word size #13435

BlocksOnAChain opened this issue Dec 17, 2024 · 0 comments
Labels
MT cannon - audit findings grouping for audit findings MT cannon - Mainnet relevant issues needed to complete the work for our Mainnet release

Comments

@BlocksOnAChain
Copy link

As per spearbit audit finding, we have the following finding:

Description
Comment says 4 bytes, but it is actually the word size. Also, the comment is bellow the aligning operation.

Recommendation
Move the comment above the aligning, and use "word size" instead of "4 bytes".

packages/contracts-bedrock/src/cannon/libraries/MIPS64Syscalls.sol
// mask the addr to align it to 4 bytes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
MT cannon - audit findings grouping for audit findings MT cannon - Mainnet relevant issues needed to complete the work for our Mainnet release
Projects
Proofs team - Project Delivery tracking board
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BlocksOnAChain