Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add WaitLeader function to common framework #14305

Closed
clement2026 opened this issue Aug 3, 2022 · 0 comments
Closed

tests: add WaitLeader function to common framework #14305

clement2026 opened this issue Aug 3, 2022 · 0 comments

Comments

@clement2026
Copy link
Contributor

Background and Purpose

In the process of migrating tests to common framework(see #13637), I found there are many test cases depending on WaitLeader function, which blocks callers until all endpoints agree on the same leader.

Operations such as member add and move-leader would fail before all endpoints agree on the same leader. To test these operations properly, it is recommended that a WaitLeader function should be added to common framework.

What I have done

WaitLeader function has already been implemented in integration cluster, but not in e2e cluster.
I have written some code(#14304 ) to implement it in e2e cluster, and added it to common framework.

As I'm new to ETCD, I would love to hear more advice👏

btw

This image shows where existing WaitLeader function is referenced:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant