Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LEDC on ESP32: SpeedMode is currently a config, but it should actually be modelled as a peripheral #423

Closed
ivmarkov opened this issue May 23, 2024 · 2 comments
Closed

LEDC on ESP32: SpeedMode is currently a config, but it should actually be modelled as a peripheral #423

ivmarkov opened this issue May 23, 2024 · 2 comments

Comments

@ivmarkov
Copy link
Collaborator

Esp32 is the only chip which does have two groups of channels:

  • High speed group of 8 channels implemented in hardware (only esp32)
  • Low speed group of 8 channels implemented in software (esp32 and all others)

The way the LEDC driver is implemented right now.... you can't really use both groups simultaneously, as the peripheral is a... single one...

Changes necessary:

  • Remove SpeedMode config
  • Define a new peripheral - say - LEDCF (F = fast) - with #[cfg(esp32)]

... because with just 8 channels, you can't drive 3 rgb leds, if I understand it correctly.... :)
@ivmarkov
Copy link
Collaborator Author

@Vollbrecht ^^^ I'll probably open a PR for this shortly. Need to drive 3 leds on an esp32...
Please let me know if I'm missing something.

@ivmarkov
Copy link
Collaborator Author

Addressed by #424

@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
esp-rs
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ivmarkov @Vollbrecht