Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model executable vs model name #11

Open
joakimkjellsson opened this issue Jun 12, 2020 · 5 comments
Open

Model executable vs model name #11

joakimkjellsson opened this issue Jun 12, 2020 · 5 comments
Assignees

Comments

@joakimkjellsson
Copy link
Contributor

Hi y'all

I started working on focioifs (OpenIFS+NEMO+XIOS+Runoffmapper) and realised that the way ESM-Tools are written we assume that the executable name, i.e. what is generated when compiling, is the same as the model name when OASIS_INIT_COMP is called and what is written under "NBMODEL" in namcouple.

Typically I would write

$NBMODEL
3 oceanx oifs rnfma
$END

in namcouple, but the executables are named "nemo.exe", "master.exe" and "rnfmap.exe".
But now I get

$NBMODEL
3 oceanx master.exe rnfmap.exe
$END

in the namcouple file and OASIS can't connect these names with what is sent to OASIS_INIT_COMP from the models.

Is there a way to specify a model name under NBMODEL that is not the same as the executable name?

Cheers
Joakim

@seb-wahl
Copy link
Contributor

seb-wahl commented Jun 12, 2020

I had the same problem with FOCI and just renamed the exectutable (nemo.exe --> oceanx) after compilation. See setup2models.yaml

@pgierz pgierz self-assigned this Jun 16, 2020
@pgierz
Copy link
Member

pgierz commented Jun 16, 2020

Hi guys...currently, the coupler is hard coded to use the name under executable. We can change that to allow the configuration to also specify a coupler name, which would be used if defined, and otherwise it will use the executable name.

@joakimkjellsson: do you have a preference? coupler_name? You'd have to put in your OpenIFS.yaml:

model: oifs
#... other stuff ...
coupler_name: oifs
executable: master.exe

@pgierz pgierz transferred this issue from esm-tools/esm_tools Jun 16, 2020
@joakimkjellsson
Copy link
Contributor Author

Hi Paul
Something like "coupler_name" would make a lot of sense!
Cheers
Joakim

@pgierz
Copy link
Member

pgierz commented Oct 16, 2021

(1.5 years later...) Did this ever get taken care of? I am making my to-do list for next week. If not, I will add it for Monday.

@joakimkjellsson
Copy link
Contributor Author

Hi Paul

I don't think so. Currently we do what @seb-wahl said, i.e. rename the executables.
It's not a priority to solve this as far as I'm concerned, but if it's a fast fix, then I recommend using the "coupler_name" as above, and setting it to be e.g. "oifs", "oceanx" etc by default to make sure nothing breaks.

Cheers
Joakim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants