Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Value needs to escape double quotes to html entities. #10

Open
bb-nerd opened this issue May 27, 2021 · 0 comments · May be fixed by #11
Open

Value needs to escape double quotes to html entities. #10

bb-nerd opened this issue May 27, 2021 · 0 comments · May be fixed by #11

Comments

@bb-nerd
Copy link

bb-nerd commented May 27, 2021

It is possible for certain attributes to include values such as "I said, "Hello World" to my friend." By not escaping these values we break the HTML structure.

Drupal's Attribute class renders with this assumption and is escaped with an html_attr context. We should be doing the same.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Escape double quotes on attribute values and add tests. bb-nerd/drupal-attribute
1 participant
@bb-nerd