-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--preset=merge
for moz-webgpu-cts process-reports
#9
Labels
Comments
CC @jmaher, in case it's interesting for discussing later. |
ErichDonGubler
changed the title
Implement
Implement Oct 19, 2023
moz-webgpu-cts extend-expected-from <wptreport.json glob>
moz-webgpu-cts adjust --extend …
3 tasks
ErichDonGubler
changed the title
Implement
Implement Oct 19, 2023
moz-webgpu-cts adjust --extend …
moz-webgpu-cts adjust-exps --extend …
ErichDonGubler
changed the title
Implement
Implement Oct 23, 2023
moz-webgpu-cts adjust-exps --extend …
moz-webgpu-cts adjust-exps --stage=extend-intermittents …
This was referenced Oct 23, 2023
ErichDonGubler
changed the title
Implement
Oct 24, 2023
moz-webgpu-cts adjust-exps --stage=extend-intermittents …
--on-conflict=merge
heuristic for moz-webgpu-cts adjust-exps
ErichDonGubler
changed the title
Oct 24, 2023
--on-conflict=merge
heuristic for moz-webgpu-cts adjust-exps
--on-conflict=merge-both
heuristic for moz-webgpu-cts adjust-exps
ErichDonGubler
changed the title
Oct 24, 2023
--on-conflict=merge-both
heuristic for moz-webgpu-cts adjust-exps
--on-conflict=accept-both
heuristic for moz-webgpu-cts adjust-exps
ErichDonGubler
changed the title
Oct 24, 2023
--on-conflict=accept-both
heuristic for moz-webgpu-cts adjust-exps
--on-conflict=accept-both
heuristic for moz-webgpu-cts process-reports
ErichDonGubler
changed the title
Oct 24, 2023
--on-conflict=accept-both
heuristic for moz-webgpu-cts process-reports
--on-conflict=accept-both
for moz-webgpu-cts process-reports
This is being implemented as |
ErichDonGubler
changed the title
Nov 2, 2023
--on-conflict=accept-both
for moz-webgpu-cts process-reports
--preset=merge
for moz-webgpu-cts process-reports
ErichDonGubler
moved this from Todo
to In Progress
in Automate WebGPU CTS adjustments for Firefox
Nov 2, 2023
Closed with #14. |
github-project-automation
bot
moved this from In Progress
to Done
in Automate WebGPU CTS adjustments for Firefox
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Depends on #13 for concept and implementation.
I, a developer of Firefox's implementation of WebGPU, often encounter distinct phases of expectation adjustment when I make changes to Firefox. Usually, I first discover all expected permanent outcomes for a revision of Firefox's code (perhaps with the help of
moz-webgpu-cts process-reports …
from #13!). Afterwards, there is often another phase in which I have not yet discovered all intermittent test cases. This activity tends to require a high number of test executions to adjust new expectations adequately.Fortunately, to an even extent greater than
reset-*
heuristics, this task is automatable. The inputs and flow will be similar. I wantmoz-webgpu-cts process-reports
to adjusts expectations to be the union of outcomes in current metadata and in processed reports.Q: Why can we not use
./mach wpt-update --update-intermittent …
?./mach wpt-update --update-intermittent …
appears to not implement behavior documented at theUpdating Expectations
section ofwptrunner
(emphasis mine):Once upon a time, WebGPU CTS had expectations like this for tests that had a large number of small subtests:
Because the
./mach wpt-update …
script only emits observedTIMEOUT
andNOTRUN
outcomes to test metadata, I wanted to manually make an update, so that these tests would always haveTIMEOUT
andNOTRUN
together as accepted intermittent subtest outcomes, namely:I expected
./mach wpt-update …
to maintain these intermittent statuses unless--remove-intermittent
was specified. However, running./mach wpt-update --update-intermittent …
instead removed theTIMEOUT
andNOTRUN
statuses that I had added, despite not specifying--remove-intermittent
. That is,wpt-update
acted as I would expect if--remove-intermittent
were also specified.The text was updated successfully, but these errors were encountered: