Skip to content

Commit

Permalink
Tests: c3voc: nitpick: prefer is to == for boolean comparisons.
Browse files Browse the repository at this point in the history
  • Loading branch information
jayaddison committed Sep 1, 2024
1 parent 0788cd4 commit b996797
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions tests/test_api_c3voc.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def test_update_voctoweb_with_correct_url(client, app, db, proposal):

proposal = Proposal.query.get(proposal.id)
assert proposal.c3voc_url == "https://media.ccc.de/"
assert proposal.video_recording_lost == False
assert proposal.video_recording_lost is False
assert proposal.youtube_url is None


Expand Down Expand Up @@ -178,7 +178,7 @@ def test_denies_voctoweb_with_wrong_url(client, app, db, proposal):

proposal = Proposal.query.get(proposal.id)
# setup sets this to true, the api should not change that
assert proposal.video_recording_lost == True
assert proposal.video_recording_lost is True
assert proposal.c3voc_url == "https://example.com"


Expand Down Expand Up @@ -365,7 +365,7 @@ def test_update_youtube_with_correct_url(client, app, db, proposal):

proposal = Proposal.query.get(proposal.id)
assert proposal.c3voc_url is None
assert proposal.video_recording_lost == False
assert proposal.video_recording_lost is False
assert proposal.youtube_url == "https://www.youtube.com/watch"


Expand Down Expand Up @@ -401,7 +401,7 @@ def test_denies_youtube_update_with_exisiting_url(client, app, db, proposal):

proposal = Proposal.query.get(proposal.id)
# setup sets this to true, the api should not change that
assert proposal.video_recording_lost == True
assert proposal.video_recording_lost is True
assert proposal.youtube_url == "https://example.com"


Expand Down Expand Up @@ -437,7 +437,7 @@ def test_denies_youtube_update_with_wrong_url(client, app, db, proposal):

proposal = Proposal.query.get(proposal.id)
# setup sets this to true, the api should not change that
assert proposal.video_recording_lost == True
assert proposal.video_recording_lost is True
assert proposal.youtube_url == "https://example.com"


Expand Down

0 comments on commit b996797

Please sign in to comment.