Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Tolerance Handling for Numerical Parameters #375

Closed
Scienfitz opened this issue Sep 9, 2024 · 1 comment
Closed

Refactor Tolerance Handling for Numerical Parameters #375

Scienfitz opened this issue Sep 9, 2024 · 1 comment
Labels
enhancement Expand / change existing functionality refactor

Comments

@Scienfitz
Copy link
Collaborator

Tolerance handling needs to be refactored to distinguish two different situations

  • how tolerant is the algo to points that lie completely outside of the allowed parameter range (min/max for discrete parameters). This is important as scaling should be done absed on allowed values, and if values are provided that are substantially outside of that range it could lead to problems. This affects discrete as well as continuous parameters
  • how tolerant is the algo towards points that lie close but not exactly on discrete sets of values. This is currently implemented but needs a refactor to be consistent and different to the above point. This only relates to discrete parameters
@Scienfitz Scienfitz added enhancement Expand / change existing functionality refactor labels Sep 9, 2024
@Scienfitz Scienfitz changed the title Refactor tolerance handling Refactor Tolerance Handling for Numerical Parameters Sep 9, 2024
@AdrianSosic
Copy link
Collaborator

Closed in favor of #428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Expand / change existing functionality refactor
Projects
None yet
Development

No branches or pull requests

2 participants