Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove element by value and by index #180

Closed
ismlsmile opened this issue Aug 9, 2022 · 6 comments
Closed

remove element by value and by index #180

ismlsmile opened this issue Aug 9, 2022 · 6 comments

Comments

@ismlsmile
Copy link

Could I remove an element by its value and index ?

@elliotchance
Copy link
Owner

I'm not sure if you mean you wish to remove an element when its matches an index and it's value, or if you mean you want independent processes to do either.

There is no function for removing by index (although, there should be). If you want to remove by value, you can use Filter or FilterNot.

@chocolacula
Copy link
Contributor

I am ready to implement a function for removing by index. I think issue #171 is related to this one. @elliotchance approve or correct me please and I'll do that as soon as I can.

@elliotchance
Copy link
Owner

Go for it. The linked diff was against pie v1 which I'm not supporting anymore.

@chocolacula
Copy link
Contributor

Added in #194

@chocolacula
Copy link
Contributor

@elliotchance perhaps, the issue could be closed because removing by index was implemented, and filtering function already exists.

@elliotchance
Copy link
Owner

@chocolacula yeah, good point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants