-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Making docs more verbose #17
Comments
Hi @git-anurag-hub, |
Hey @SohamRatnaparkhi, thanks for the issue but this issue will be solved on the merging of pr #16 ! Again thanks for the contribution. |
@SohamRatnaparkhi: Thanks for reporting and offering to work on this. By the way, the issue has a tempting title. It almost made me believe we had some kind of documentation... 🙃😆 Anyway, did merging #16 fully solve this issue? If not, maybe you could tell us what's left to do, and maybe do it :) Otherwise, perhaps you could work on the issue that you youself suggested "making the docs more verbose" ;-) We most definitely need documentation of the current features (not that many). That is, some screenshots with a bit of description (login, run a workflow, etc.). Something to build on anyway, as we will be adding more features. Not the most exciting issue, though, so it's totally understandable if you'd rather want to look for something more code-oriented :) |
Is your feature request related to a problem? Please describe.
When attempting to
run a workflow
locally on the localhost, we are currently redirected to theproduction deployment
of Krini, which can be found at this. This redirection prevents contributors from being able to view the changes they make to the./src/components/RunWorkflow.js
file.Describe the solution you'd like
In the
./src/config.js
,host_uri
points to the production deployment, but if this points todevelopment deployment
then the issue can be solvedAdditional context
It is likely that
host_uri
is set to point to the production deployment because it is intended for public viewing. However, we can instruct contributors not to commit any changes made in theconfig.js
file during a pull request.The text was updated successfully, but these errors were encountered: