Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Cypress e2e test to test the login flow of krini #1

Open
anuragxxd opened this issue Jun 22, 2022 · 13 comments · May be fixed by #19
Open

Implement the Cypress e2e test to test the login flow of krini #1

anuragxxd opened this issue Jun 22, 2022 · 13 comments · May be fixed by #19
Assignees
Labels
priority: high High priority type: testing Related to code testing

Comments

@anuragxxd
Copy link
Member

anuragxxd commented Jun 22, 2022

Is your feature request related to a problem? Please describe.
As the CI pipeline runs certain tests on the Krini before deploying it to the production. Checking the login flow will be a good test to be written in case OIDC auth is broken by any code changes.

Describe the solution you'd like
We can write the cypress e2e test that tests for the login flow before deploying the application to production.

Describe alternatives you've considered
--NA--

Additional context
A test can be written in the file ./cypress/e2e/spec.cy.js under the test auth -> user can login. This test is already integrated into the CI pipeline & this can be tested by running npm run cypress:open.

@anuragxxd anuragxxd added priority: high High priority type: testing Related to code testing labels Jun 22, 2022
@ghost
Copy link

ghost commented Jul 8, 2022

Hi @git-anurag-hub, can you please assign this issue to me?

@uniqueg
Copy link
Member

uniqueg commented Jul 8, 2022

Hi @tanya17-05, I think @Sanyam2000-dot is already working on this, but I'm not sure. @git-anurag-hub: can you please write some more issues and make sure both @Sanyam2000-dot and @tanya17-05 have issues to work on? Thanks 🙏🏻

@anuragxxd
Copy link
Member Author

Yeah sure @uniqueg. @Sanyam2000-dot can you confirm if you are working on this?

@Sanyam2000-dot
Copy link

Hello Anurag, Yes I'm working on this issue. Thanks!

@ghost
Copy link

ghost commented Jul 8, 2022

Ok @Sanyam2000-dot, let me know if you need any kind of help.

@Sanyam2000-dot
Copy link

Ok @Sanyam2000-dot, let me know if you need any kind of help.

Thanks @tanya17-05 . I'll ket you know.

@anuragxxd
Copy link
Member Author

Hey @Sanyam2000-dot are you working on this?

@Sanyam2000-dot
Copy link

Hello @git-anurag-hub, I have started this but have not completed it due to some health issues in the family. It will be good if you can assign it to Tanya so I can guide her forward.

@anuragxxd
Copy link
Member Author

Np @Sanyam2000-dot , TC!

@anuragxxd anuragxxd assigned ghost Aug 19, 2022
@uniqueg uniqueg unassigned Sanyam2000-dot and ghost Dec 31, 2022
@uniqueg uniqueg moved this to Todo in Front-end issues Dec 31, 2022
@SohamRatnaparkhi
Copy link
Member

SohamRatnaparkhi commented Mar 3, 2023

Hi,
Can I work on this issue? I have some experience in writing Cyprus tests.
My approach would be, using cyprus:

  • clicking the login button on home screen
  • clicking on Login with LS username
  • entering test username and password
  • clicking on login button
  • searching for Run workflow button to confirm login was successful.

Code snippet in spec.cy.js file that I wrote in my forked repo to solve this issue would be -

code-snapshot
Here, we will require some test username and password to be stored in .env which can be used for testing.
I am open for suggestions to my approach.

@anuragxxd
Copy link
Member Author

Sure @SohamRatnaparkhi, go ahead with it!

@SohamRatnaparkhi
Copy link
Member

Okay, Thank you @git-anurag-hub
What should be the test_password and test_username in this case?

@anuragxxd
Copy link
Member Author

Hey @SohamRatnaparkhi, you can right now try out with yours & configure the same in the .env.test!

@SohamRatnaparkhi SohamRatnaparkhi linked a pull request Mar 4, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high High priority type: testing Related to code testing
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

4 participants