-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[accessibility] The skip link added in version 2.6.0. is dysfunctional #217
Comments
Bovelett
changed the title
[accessibility] The skip link added on July 10 is dysfunctional
[accessibility] The skip link added on in version 2..6.0. is dysfunctional
Jul 16, 2022
Bovelett
changed the title
[accessibility] The skip link added on in version 2..6.0. is dysfunctional
[accessibility] The skip link added in version 2.6.0. is dysfunctional
Jul 16, 2022
5 tasks
+1 |
1 similar comment
+1 |
Still waiting on a fix for this. It's an accessibility failure and it matters. |
+1 |
+1 |
Does the current implementation assume that we will add an ID of "content" to one of the elements on the page? Or should it be handled automatically? Was I dreaming, or did Elementor used to output a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here's the report I promised after the dialogue with @arielk on July 15:
I will be separating this in two parts: first the geek speak, then the consequences for non-technical users:
The skip link added in version 2.6.0 on July 10 has a couple of issues.
VIDEO WALK THROUGH OF THE ISSUES FOUND
It's not a long video, and I am announcing in the beginning what will be shown.
⬇️
https://user-images.githubusercontent.com/852140/179362286-02459a8b-e4ca-4b68-9a36-2922e8cade7d.mp4
The nerd speak
<main id="content">
. But as soon as I chose to edit a web page with Elementor from the WordPress Dashboard, that ID disappeared. And then the skip link is there for naught. [UPDATE July 21: see https://github.com/♿ 🐞 <main id="content"> tag disappears upon setting Page Layout to Elementor Full Width elementor#19215 which explains that pages individually set to full width in Elementor do not have the<main id="content"
anymore. This explains why I could never find this ID on my sites, and on that of many other Elementor Pro driven sites.]handleAnchorLinks
seems to be the culprit) was mentioned there: Accessibility: Skip links elementor#9292.However, this was in reply after that issue had been closed. So, someone opened a new thread referring to this one, which still has the "open" status and is and unassigned: Skip to content accessibility workarounds no longer work elementor#17433 Although Rami did add the bug and accessibility label to it.
Consequences and suggestions:
As happy as I am with any improvement for accessible output, and I'm glad to see that a skip link is something you deem important, I'm worried about the implementation. Accessibility has an undeserved bad reputation as it is. People think accessibility will make their site ugly. This does not help that belief and people continue to be excluded from sites.
Currently:
Dear Elementor Team, if we all work together to make online accessibility with Elementor part of that no-coding solution, and thus available to all, the world will be a more inclusive and therefore better place. And in doing so you will be light years ahead of the competition.
❤️
With warm and respectful greetings,
Anne
The text was updated successfully, but these errors were encountered: