-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Story] Indicate when calls are unsupported in the timeline/notifications #2563
Comments
Given, this is a temporary/workaround, I would keep it simple and without confirmation. I think it does not compromise privacy much, only exposes that one is using EX.
I think that is fine; even hardcoding to English is also probably fine. In terms of the message itself, I would propose something like: "Bob may not be able to answer your call since you're using legacy calling. Please use Element X to reach them". |
We had a tech discussion about it. We are all aligned that we need a long term plan for the migration from lecacy calls to Element Calls BUT we cannot go quick to implement it, even with the band aid solution described in the issue. We tried to not overthinking but we kept raising concerns. It makes think we cannot converge in a better solution than what we have now in the 1 or 2 days of work allocate for this. From the meeting:
Discussed options:
|
The current solution is that the callee gets a notification and a timeline item saying "Call in progress (unsupported)". Then, the callee can they interact with the caller to find a way to communicate. Another option could be to iterate on the wording on this not useful information in the timeline. The copy could invite the callee to engage and chat with the caller. |
Note: if by "notice" we're talking about |
Instead of just showing "Call in progress (unsupported)", could you not display the Jitsi link, so the callee may join using the Jitsi app or their browser? |
How about we spec m.call.reject code which EX can send to say "sorry, can't answer now as you need to speak MatrixRTC". We then make a trivial change to the legacy apps to display that appropriately? |
Thanks for the hint. We were focused on the DM case but we could definitely used the Jitsi link for group calls. We just™️ need to make Element X support the widget API :/
Oh, yes. @bmarty raised it too. I added it to the list |
I edited the user story indicating what we are going to experiment on Legacy and EX mobile apps. This changes follow the meeting we had with @bmarty and @pixlwave (https://docs.google.com/document/d/13GQLlgFZrJXlERKUYxaUUfm8QSqcvn937b7UBQ_AzGs/edit?tab=t.0_) |
I've updated the story with the solution we discussed in the room. |
Testing sessionAlice is on EX apps and EW. Bob, on legacy apps and EW. The tests are done for each versions of the mobile apss: EA, EXA, EI and EXI. EW can make both Element Calls and legacy calls. Legacy sideWe must have unsupported banner for:
No unsupported banner. The call just works:
EX sideWe must have unsupported banner for:
No unsupported banner. The call just works:
|
I checked some items but we need to discuss notificaiton for EC calls in legacy apps: https://github.com/element-hq/element-android-rageshakes/issues/72241. |
The EA notification bug has been fixed in element-hq/element-android#8945. The whole feature will be available in those versions of legacy and EX apps:
|
Description
Acceptance criteria
Legacy side:
m.call.notify
event will be delivered saying there is an unsupported call.m.mentions
property to make sure the notification is intended for this user, but the type doesn't matter as we will never ring.m.call.notify
event will show a timeline item to indicate an unsupported call.m.mentions
here, a call has been placed, let the user know if they're in the timeline.EX side (already implemented although we might want to tidy up the copy):
m.call
event will be delivered saying there is an unsupported call.common.unsupported_call
m.call
event will show a timeline item indicating an unsupported call.screen_room_timeline_legacy_call
Leads
Size estimate
None
Dependencies
Out of scope
Open questions
Questions
Subtasks
Android
iOS
Web
Other
bugs
Sign-off
Android
iOS
The text was updated successfully, but these errors were encountered: