Shut down the connection supervisor in case of an unrecoverable replication error #2189
+79
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alco
force-pushed
the
alco/invalidated-replication-slot
branch
from
95afd17 to
d96cc2d
Compare
…cation error The StackSupervisor will shut itself down as a result because the connection supervisor is marked as a significant child. In a multi-tenant setup, this effectively shuts down a single tenant while the other tenants keep running.
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alco
force-pushed
the
alco/invalidated-replication-slot
branch
from
d96cc2d to
3b9df57
Compare
icehaunter
requested changes
Dec 24, 2024
| # Perform supervisor shutdown in a task to avoid a circular dependency where the manager | ||
| # process is waiting for the supervisor to shut down its children, one of which is the | ||
| # manager process itself. | ||
| Task.start(Electric.Connection.Supervisor, :shutdown, [state.stack_id, error]) |
There was a problem hiding this comment.
Great job, but let's dispatch_stack_event here too, so that the control plane can be aware of what's happened and why this is down
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The StackSupervisor will shut itself down as a consequence.
In a multi-tenant setup, this effectively shuts down a single tenant while allowing the other tenants to keep chugging along.
Closes #2178.