[Search UI] breaks when user makes simple URL modifications

[fvanderwielen]

Describe the bug
With the default setup, the SDK breaks when the user modifies the URL to something that does not exactly match the format of the requestState object

To Reproduce
Steps to reproduce the behavior:
reproducible currently in the demo codesandbox environment here: https://codesandbox.io/s/github/elastic/search-ui/tree/main/examples/sandbox?from-embed=&initialpath=/elasticsearch&file=/src/pages/elasticsearch/index.js

1. Go to https://32xp9i.csb.app/elasticsearch?size=n_20_n&filters[asdfasdfasdf]
2. See error on the entire page: "An unexpected error occurred: (intermediate value).filter is not a function"

Expected behavior
A more robust error handling, for example defaulting filters to an empty array when wrong typing is found.

Screenshots

Which backends and packages are you using:
Packages: [search-ui]

Additional info
What happens is that parseing of the URL is not robust, there is only a non-falsy check but that is not enough, as other SDK code assumes that the requestState properties actually have correct type.

Parsing is not robust here:

search-ui/packages/search-ui/src/URLManager.ts

Line 66 in d37d1bf

function paramsToState(queryParams: QueryParams): RequestState {

This SDK code here assumes filters to be an array (as it assumes filters.filter to be a function), which is is not in the reproduction scenario, and no safeguards exist against this:

search-ui/packages/search-ui/src/actions/clearFilters.ts

Line 15 in d37d1bf

const updatedFilters = filters.filter((filter) => {

[botelastic]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.

[fvanderwielen]

I still think this bugfix is important, it makes the SDK less brittle against what is from my perspective realistic user behavior.

[joemcelroy]

thanks for reporting the issue. Will add it to list of improvements

[botelastic]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.

[fvanderwielen]

still think so, also getting a bit tired of the configuration of the issue bot...

[botelastic]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.

[fvanderwielen]

still think so, also getting quite a bit more tired of the configuration of the issue bot...

[botelastic]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.

[fvanderwielen]

#1003 (comment)

[botelastic]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.

[fvanderwielen]

justintimberlakestare.gif