Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to determine whether development dependencies have been installed #5633

Closed
joshuaspence opened this issue Jul 13, 2016 · 2 comments
Closed

Comments

@joshuaspence
Copy link

The logstash-plugin command can be used to install plugins (with logstash-plugin install ${NAME}) and also to check whether a plugin has been installed (with logstash-plugin list ${NAME}). The logstash-plugin command can also be used to install development dependencies (with logstash-plugin install --development), however I am unable to use logstash-plugin list --development in order to check whether the development dependencies have been installed. Is there some other way that I can check whether the development dependencies have been installed? For additional context, see voxpupuli/puppet-logstash#292.

@purbon
Copy link
Contributor

purbon commented Jul 20, 2016

@joshuaspence the situation here is complex I think, for one side we added the --development flag to make sure all development dependencies for test are being installed, mainly for the logstash developer who is actually running the tests.

logstash-plugin list main task is to list plugins, not it's dependencies, so it should be expected it can not list them.

The only way to check for development dependencies to be installed is either the stdout message you will get or by parsing the Gemfile.lock generated after the installation.

on the other side, to actually run your test, I do not recommend using rspec for this task. checking for configuration it might be better done in integration fashion maner, thinking about LS as a black box.

closing this issue for now, happy to reopen.

@purbon purbon closed this as completed Jul 20, 2016
@joshuaspence
Copy link
Author

So there are no plans to fix this? Recommend treating Logstash as a black box, I really don't know how to go about implementing that. There is some similar discussions in #6479, but it doesn't seem like anyone has a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants