-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: instrument @elastic/elasticsearch
package
#28
Comments
@elastic/elasticsearch
package@elastic/elasticsearch
package
Note to self: check with clients team first |
There is https://github.com/aspecto-io/opentelemetry-ext-js/tree/master/packages/instrumentation-elasticsearch as well if we wanted. |
IIUC this PR adds OTEL instrumentation natively in elasticsearch client rigtht? If so we should add only instrumentation for elasticsearch's versions using a |
We should add a test/isntr-elasticsearch.test.js to sanity check that it works. (I tried locally and it does not.) I got this trace:
using:
|
@david-luna I could steal this one if you like. I had a start at adding instr-elasticsearch.test.js locally. (Note to self: g eon3) |
I have a draft PR to add a test here: #264 |
@trentm ill be happy to review your PR :) |
This instrumentation is not in any of the opentelemetry repos. That would be a good example for instrumentations we could provide earlier in our distro before promoting them to upstream.
The text was updated successfully, but these errors were encountered: