Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when customizing the Siren standard UI #50

Open
FelixEder opened this issue Feb 22, 2019 · 1 comment
Open

Bug when customizing the Siren standard UI #50

FelixEder opened this issue Feb 22, 2019 · 1 comment

Comments

@FelixEder
Copy link

I'm trying to display a custom UI when the app is out of date instead of the standard dialog provided in this library. I do this by following the README from the "Example"-section. When I follow that exact code (create my own ISirenListener and add my own UI in the onShowUpdateDialog-method) and set all Siren Alert-types to NONE, I get this error:

I open the app (I have a lower version number hard coded for testing so it will always be called) and my own custom UI is displayed. However, the standard Siren UI is still displayed underneath my own UI. When I close my own UI I can then see the Siren UI. I tried this for a custom dialog and standard snackbar and I get the same result for both.

I don't understand, if I set the Alert-types to NONE, then why does the standard Siren UI still appear? I only want my own UI to show.

@mikemee
Copy link
Collaborator

mikemee commented Feb 22, 2019

Hi @FelixEder, offhand I’m not sure, but the source code is there so it should be possible to debug it. And the tests might be useful as an example too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants