Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackedTable with bits_per_item 5,7,9 does not work #34

Open
vidhoonv opened this issue Jun 15, 2018 · 4 comments · May be fixed by #35
Open

PackedTable with bits_per_item 5,7,9 does not work #34

vidhoonv opened this issue Jun 15, 2018 · 4 comments · May be fixed by #35

Comments

@vidhoonv
Copy link

Hi,

Thanks for writing this library for cuckoo filter. I tried to do some benchmarking and found that while setting bits per item to 5 or 7 or 9 with Packedtable config - the filter does not work. It ends up saying that filter does not contain the item that was added (false negatives). Is this known issue ? The issue can be reproduced by using the test.cc file in the repo and changing line 52 to configure the filter to PackedTable and bits per item to 5 or 7 or 9.

@jbapple-cloudera
Copy link
Contributor

See also #6. That said, this should have a static_assert.

@vidhoonv
Copy link
Author

Thanks @jbapple-cloudera for the suggestion. The suggestion in #6 applies for SingleTable. I see that PackedTable supports bits_per_tag = 5,7,8,9,13,17 from PackedTable.h.

jbapple-cloudera added a commit to jbapple-cloudera/cuckoofilter that referenced this issue Jun 15, 2018
Previously this would fail silently at run time.

This closes efficient#34.
jbapple-cloudera added a commit to jbapple-cloudera/cuckoofilter that referenced this issue Jun 15, 2018
Previously this would fail silently at run time.

This closes efficient#34.
@jbapple-cloudera jbapple-cloudera linked a pull request Jun 15, 2018 that will close this issue
@vidhoonv
Copy link
Author

vidhoonv commented Jun 15, 2018

@jbapple-cloudera I am not sure how your commit d17dda3 would address my question/issue. In the case of PackedTable, bits_per_tag = 5,7,8,9,13,17 are supported and valid to use. But the filter fails while testing an item for its presence. I think it is an issue with the PackedTable implementation.

@jbapple
Copy link

jbapple commented Dec 15, 2019

@vidhoonv Good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants