feat: REV-4051 | allow edx_django_service to be provided with specifi… #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopappas
commented
May 20, 2024
|
There's another pattern I've seen in this repo where edx_django_service computes a default and then allows it to be overridden by services -- but it really gets quite verbose to chain it all through, so I like this list approach. |
timmc-edx
reviewed
May 20, 2024
timmc-edx
reviewed
May 20, 2024
…c app names to run datadog on fix: interpolation for DD installation conditional. also formatting fix: Apply suggestions from code review Co-authored-by: Tim McCormack <[email protected]> fix: update variable name fix: update j2 file with new conditional
christopappas
force-pushed
the
cpappas/REV-4051
branch
from
1854931 to
5bde1ec
Compare
timmc-edx
reviewed
May 22, 2024
timmc-edx
reviewed
May 22, 2024
playbooks/roles/edx_django_service/templates/edx/app/app/app.sh.j2
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim McCormack <[email protected]>
timmc-edx
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…c app names to run datadog on
Make sure that the following steps are done before merging: