Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No focus trap in modal dialogs #9894

Open
Infuser opened this issue Aug 12, 2021 · 2 comments · May be fixed by #14647
Open

No focus trap in modal dialogs #9894

Infuser opened this issue Aug 12, 2021 · 2 comments · May be fixed by #14647
Assignees
@martin-fleck-at
Labels
dialogs issues related to dialogs enhancement issues that are enhancements to current functionality - nice to haves

Comments

@Infuser
Copy link

Infuser commented Aug 12, 2021 •
edited
Loading

Hi Theia Team

When I open the open dialog from the file menu I can tab through the fields in the modal dialog and end up in the UI behind, are there any plans to get this changed.

My expectation using tab key is focus should stay inside the modal dialog and not end up in the fields behind the modal

image
@vince-fugnitto vince-fugnitto added dialogs issues related to dialogs enhancement issues that are enhancements to current functionality - nice to haves labels Aug 12, 2021
@vince-fugnitto
Copy link
Member

@Infuser thank you for reporting the issue, I believe it should be addressed 👍 Is it something you are interested in contributing?

@Infuser
Copy link
Author

Infuser commented Aug 12, 2021

A colleague is going to look into our corporate policy on contributing I will get back to you

martin-fleck-at added a commit that referenced this issue Dec 18, 2024
@martin-fleck-at
Prevent tabbing outside of dialog overlay
4891fa2 
Fixes #9894
@martin-fleck-at martin-fleck-at self-assigned this Dec 18, 2024
@martin-fleck-at martin-fleck-at linked a pull request Dec 18, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martin-fleck-at martin-fleck-at

Labels
dialogs issues related to dialogs enhancement issues that are enhancements to current functionality - nice to haves
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent tabbing outside of dialog overlay eclipse-theia/theia
3 participants
@Infuser @martin-fleck-at @vince-fugnitto