Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity bar: add setting to customize position #14600

Open
nimo23 opened this issue Dec 9, 2024 · 2 comments
Open

Activity bar: add setting to customize position #14600

nimo23 opened this issue Dec 9, 2024 · 2 comments
Labels
preferences issues related to preferences proposal feature proposals (potential future features) shell issues related to the core shell ui/ux issues related to user interface / user experience

Comments

@nimo23
Copy link

nimo23 commented Dec 9, 2024

Feature Description:

In VSCode, we can adjust the position of the Activity bar (for accessibility and/or preference reasons):

activitybar-position

Please add this kind of setting in the Eclipse Theia Activity Bar as well. Actually, it is very inflexible to stick to only one position. It should be possible to set it at the top, right, left (default) or bottom.

@msujew msujew added shell issues related to the core shell proposal feature proposals (potential future features) ui/ux issues related to user interface / user experience preferences issues related to preferences labels Dec 9, 2024
@nimo23
Copy link
Author

nimo23 commented Dec 9, 2024

I'm trying to understand the backporting process from VSCode to Theia. Will this issue be (automatically) resolved after backporting the current VSCode to Theia?

As I understand it, Theia only uses (or extends) a small part of the VSCode project (e.g. the Monaco Editor but not the Monaco Workbench). In this case, the Monaco ActivityBar is a part of the Monaco Workbench.

Why, for example, doesn't it make sense to also use or extend the VSCode's "Monaco Workbench" and "Monaco Navigator Tree" instead of reimplementing them?

@msujew
Copy link
Member

msujew commented Dec 9, 2024

Hey @nimo23,

Theia is not a fork of VS Code, we essentially just use the Monaco editor from it. We use a modified version of the monaco-editor package, which comes without any VS Code features aside from the actual HTML-based editor. All other code is written by the Theia team.

The reason why we don't use any other of VS Code's source code is pretty simple: Flexibility. VS Code's workbench is pretty inflexible, with regards to overrides. I.e. you cannot simply subclass it and rebind it like in the Theia framework to adjust the behavior for your use case. That's how people build stuff like the Arduino IDE on top of the Theia framework.

Since we don't have any backporting process from VS Code, a feature such as this will be written from scratch specifically for our application shell infrastructure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences issues related to preferences proposal feature proposals (potential future features) shell issues related to the core shell ui/ux issues related to user interface / user experience
Projects
None yet
Development

No branches or pull requests

2 participants