Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Invalid project description" #1619

Open
jukzi opened this issue Nov 15, 2024 · 9 comments
Open

"Invalid project description" #1619

jukzi opened this issue Nov 15, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@jukzi
Copy link
Contributor

jukzi commented Nov 15, 2024

After updating my platform workspace i found the following exception in my log:

org.eclipse.oomph.resources.backend.BackendException: org.eclipse.core.internal.resources.ResourceException: Invalid project description.
	at org.eclipse.oomph.resources.backend.BackendContainer.importIntoWorkspace(BackendContainer.java:158)
	at org.eclipse.oomph.targlets.core.WorkspaceIUInfo.importIntoWorkspace(WorkspaceIUInfo.java:108)
	at org.eclipse.oomph.targlets.internal.core.WorkspaceIUImporter$3.run(WorkspaceIUImporter.java:176)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2457)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2477)
	at org.eclipse.oomph.targlets.internal.core.WorkspaceIUImporter.updateWorkspace(WorkspaceIUImporter.java:147)
	at org.eclipse.oomph.targlets.internal.core.WorkspaceIUImporter$2.run(WorkspaceIUImporter.java:117)
	at org.eclipse.oomph.util.pde.TargetPlatformUtil.runWithTargetPlatformService(TargetPlatformUtil.java:120)
	at org.eclipse.oomph.targlets.internal.core.WorkspaceIUImporter.updateWorkspace(WorkspaceIUImporter.java:75)
	at org.eclipse.oomph.targlets.internal.core.WorkspaceIUImporter$ImportProjectsJob.run(WorkspaceIUImporter.java:216)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
Caused by: org.eclipse.core.internal.resources.ResourceException: Invalid project description.
	at org.eclipse.core.internal.resources.Project.checkDescription(Project.java:211)
	at org.eclipse.core.internal.resources.Project.assertCreateRequirements(Project.java:95)
	at org.eclipse.core.internal.resources.Project.create(Project.java:305)
	at org.eclipse.core.internal.resources.Project.create(Project.java:291)
	at org.eclipse.oomph.resources.ResourcesUtil.importProject(ResourcesUtil.java:304)
	at org.eclipse.oomph.resources.backend.LocalBackendSystem.importIntoWorkspace(LocalBackendSystem.java:139)
	at org.eclipse.oomph.resources.backend.BackendContainer.importIntoWorkspace(BackendContainer.java:146)
	... 10 more

image
image

At least i would like to know which project the exception is complaining about in the exception message.

@jukzi
Copy link
Contributor Author

jukzi commented Dec 17, 2024

@merks Ed can you take a look please? The enhanced error message now blame some oomph related things:

org.eclipse.oomph.resources.backend.BackendException: org.eclipse.core.internal.resources.ResourceException: Invalid project description for project 'org.eclipse.platform.ui.setup' at 'file:/C:/Users/jkubitz/platform-2024-09-23/git/eclipse.platform.ui/releng/org.eclipse.ui.releng' 
	at org.eclipse.oomph.resources.backend.BackendContainer.importIntoWorkspace(BackendContainer.java:158)
	at org.eclipse.oomph.targlets.core.WorkspaceIUInfo.importIntoWorkspace(WorkspaceIUInfo.java:108)
	at org.eclipse.oomph.targlets.internal.core.WorkspaceIUImporter$3.run(WorkspaceIUImporter.java:176)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2457)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2477)
	at org.eclipse.oomph.targlets.internal.core.WorkspaceIUImporter.updateWorkspace(WorkspaceIUImporter.java:147)
	at org.eclipse.oomph.targlets.internal.core.WorkspaceIUImporter$2.run(WorkspaceIUImporter.java:117)
	at org.eclipse.oomph.util.pde.TargetPlatformUtil.runWithTargetPlatformService(TargetPlatformUtil.java:120)
	at org.eclipse.oomph.targlets.internal.core.WorkspaceIUImporter.updateWorkspace(WorkspaceIUImporter.java:75)
	at org.eclipse.oomph.targlets.internal.core.WorkspaceIUImporter$ImportProjectsJob.run(WorkspaceIUImporter.java:216)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
Caused by: org.eclipse.core.internal.resources.ResourceException: Invalid project description for project 'org.eclipse.platform.ui.setup' at 'file:/C:/Users/jkubitz/platform-2024-09-23/git/eclipse.platform.ui/releng/org.eclipse.ui.releng' 
	at org.eclipse.core.internal.resources.Project.checkDescription(Project.java:211)
	at org.eclipse.core.internal.resources.Project.assertCreateRequirements(Project.java:95)
	at org.eclipse.core.internal.resources.Project.create(Project.java:305)
	at org.eclipse.core.internal.resources.Project.create(Project.java:291)
	at org.eclipse.oomph.resources.ResourcesUtil.importProject(ResourcesUtil.java:304)
	at org.eclipse.oomph.resources.backend.LocalBackendSystem.importIntoWorkspace(LocalBackendSystem.java:139)
	at org.eclipse.oomph.resources.backend.BackendContainer.importIntoWorkspace(BackendContainer.java:146)
	... 10 more

and

org.eclipse.oomph.resources.backend.BackendException: org.eclipse.core.internal.resources.ResourceException: Invalid project description for project 'org.eclipse.platform.sdk.setup' at 'file:/C:/Users/jkubitz/platform-2024-09-23/git/eclipse.platform.releng.aggregator/oomph' 
	at org.eclipse.oomph.resources.backend.BackendContainer.importIntoWorkspace(BackendContainer.java:158)
	at org.eclipse.oomph.targlets.core.WorkspaceIUInfo.importIntoWorkspace(WorkspaceIUInfo.java:108)
	at org.eclipse.oomph.targlets.internal.core.WorkspaceIUImporter$3.run(WorkspaceIUImporter.java:176)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2457)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2477)
	at org.eclipse.oomph.targlets.internal.core.WorkspaceIUImporter.updateWorkspace(WorkspaceIUImporter.java:147)
	at org.eclipse.oomph.targlets.internal.core.WorkspaceIUImporter$2.run(WorkspaceIUImporter.java:117)
	at org.eclipse.oomph.util.pde.TargetPlatformUtil.runWithTargetPlatformService(TargetPlatformUtil.java:120)
	at org.eclipse.oomph.targlets.internal.core.WorkspaceIUImporter.updateWorkspace(WorkspaceIUImporter.java:75)
	at org.eclipse.oomph.targlets.internal.core.WorkspaceIUImporter$ImportProjectsJob.run(WorkspaceIUImporter.java:216)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
Caused by: org.eclipse.core.internal.resources.ResourceException: Invalid project description for project 'org.eclipse.platform.sdk.setup' at 'file:/C:/Users/jkubitz/platform-2024-09-23/git/eclipse.platform.releng.aggregator/oomph' 
	at org.eclipse.core.internal.resources.Project.checkDescription(Project.java:211)
	at org.eclipse.core.internal.resources.Project.assertCreateRequirements(Project.java:95)
	at org.eclipse.core.internal.resources.Project.create(Project.java:305)
	at org.eclipse.core.internal.resources.Project.create(Project.java:291)
	at org.eclipse.oomph.resources.ResourcesUtil.importProject(ResourcesUtil.java:304)
	at org.eclipse.oomph.resources.backend.LocalBackendSystem.importIntoWorkspace(LocalBackendSystem.java:139)
	at org.eclipse.oomph.resources.backend.BackendContainer.importIntoWorkspace(BackendContainer.java:146)
	... 10 more

@merks
Copy link
Contributor

merks commented Dec 17, 2024

Is there something off about the about the content of this file, i.e., the .project file located at file:/C:/Users/jkubitz/platform-2024-09-23/git/eclipse.platform.ui/releng/org.eclipse.ui.releng:

image

image

This works fine for me and as you can see in the first picture, the project is imported into the workspace so the description file must be fine.

@jukzi
Copy link
Contributor Author

jukzi commented Dec 17, 2024

i can't see the project in my package explorer even though git "import project" says it is already imported
image
image

@jukzi
Copy link
Contributor Author

jukzi commented Dec 17, 2024

i found it in package explorer - with a wrong name?
image

it was recently renamed 2a523839813b20be41480d42e43e4ba42bd87bae

@merks
Copy link
Contributor

merks commented Dec 17, 2024

That leaves the workspace in kind of an inconsistent state. I suppose if you delete the project (without deleting it on disk), it will be imported with the correct name and the problem will go away...

@jukzi
Copy link
Contributor Author

jukzi commented Dec 17, 2024

ok, thanks that helped fixing it.
image
Maybe one should move the project path to stick with the pattern, that name and path are the same @HannesWell

@merks
Copy link
Contributor

merks commented Dec 17, 2024

Yes, it's kind of confusing when the folder and IProject names are different...

@HannesWell
Copy link
Member

Maybe one should move the project path to stick with the pattern, that name and path are the same @HannesWell

This was done in an attempt to have a similar naming pattern for all projects containing setups without changing the paths of the setups. Because the latter is much more work, because it requires adjustments of the Oomph index. Not impossible, but more work.

@merks
Copy link
Contributor

merks commented Dec 18, 2024

Yes, this is referenced via absolute URI from another setup, i.e., this one. So if the path were to be changed, the URI would need to be changed here:

https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/420650837e7249e2a58714554f074f22ff4be764/oomph/Platform.setup#L922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants