Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphNode.setNodeStyle() doesn't work for ZestStyles.NODES_HIDE_TEXT #647

Open
ptziegler opened this issue Jan 2, 2025 · 0 comments
Open

Comments

@ptziegler
Copy link
Contributor

ptziegler commented Jan 2, 2025

The style of a Zest graph node can either be set via the constructor or the setNodeStyle method. Similar to #639, I think it's a good practice to only use the setNodeStyle method, to have a clear separation between Zest and SWT styles.

Sadly, this doesn't work for all Zest styles, as e.g. the NODES_HIDE_TEXT only works when used within the constructor. This is because the underlying figure is initialized together with the graph node and never updated in case the style has changed.

Note: I don't want to prohibit the use of Zest styles in the constructor, though I would like to update our examples to use the latter as the "proper" way to use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant