New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn't this just check for RM liquidation? #711

Open

GalloDaSballo opened this issue Oct 19, 2023 · 0 comments

Collaborator

GalloDaSballo commented Oct 19, 2023

https://github.com/Badger-Finance/ebtc/blob/d39d14b125f1957abac6ac31cc8066950d5219e3/packages/contracts/contracts/LiquidationLibrary.sol#L83

Seems like the check checks twice for ICR < MCR, costs tens of extra gas (no biggie)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment