Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: create test items, list and list_items for query & interface testing #358

Closed
1 task done
nelsonic opened this issue Apr 20, 2023 · 1 comment
Closed
1 task done

Chore: create test items, list and list_items for query & interface testing #358

nelsonic opened this issue Apr 20, 2023 · 1 comment
Assignees
@nelsonic
Labels
chore a tedious but necessary task often paying technical debt elixir Pull requests that update Elixir code enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! priority-1 Highest priority issue. This is costing us money every minute that passes. T2h Time Estimate 2 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented Apr 20, 2023 •
edited
Loading

At present I find myself having to write a bunch of boilerplate code to write tests for the work I'm doing in #356 & #357 ... 👨‍💻 ⌛
Feel like I could create a couple of realistic-looking lists and list_items for the person=1 ("admin") which only get inserted in a MIX_ENV=test or MIX_ENV=dev so they don't pollute prod.

Todo

  • extend priv/repo/seeds_test.exs with lists and list_items including updating the position and "removing" items (position=999999.999) so we can test the list_items query.
@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! T2h Time Estimate 2 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies priority-1 Highest priority issue. This is costing us money every minute that passes. chore a tedious but necessary task often paying technical debt elixir Pull requests that update Elixir code labels Apr 20, 2023
@nelsonic nelsonic self-assigned this Apr 20, 2023
@nelsonic nelsonic moved this to 🔖 Ready for Development in dwyl app kanban Apr 20, 2023
@nelsonic nelsonic mentioned this issue Apr 20, 2023
Closed
3 tasks
nelsonic added a commit that referenced this issue Apr 22, 2023
@nelsonic
add dummy data for testing lists & list_items closes #358
5bd136b
nelsonic added a commit that referenced this issue Apr 22, 2023
@nelsonic
mix format !! #358
ebb5a94
@nelsonic
Copy link
Member Author

Included in: https://github.com/dwyl/mvp/pull/345/files#diff-c47a1aff9bf95e01794823e9077bbcf6c1b6321beadf2ace8ee9496415766c88

@github-project-automation github-project-automation bot moved this from 🔖 Ready for Development to ✅ Done in dwyl app kanban Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

Labels
chore a tedious but necessary task often paying technical debt elixir Pull requests that update Elixir code enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! priority-1 Highest priority issue. This is costing us money every minute that passes. T2h Time Estimate 2 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic