Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(n more) is shown for notifications under the current pause level. #1294

Open
SeerLite opened this issue Feb 28, 2024 · 4 comments
Open

(n more) is shown for notifications under the current pause level. #1294

SeerLite opened this issue Feb 28, 2024 · 4 comments

Comments

@SeerLite
Copy link
Contributor

Issue description

If the pause level is set to 100 (i.e. dunstctl set-paused true), and there is a notification that doesn't override said pause level then it is hidden. However, if at the same time a single notification that overrides 100 is sent, dunst displays a (1 more) pseudo-notification, taking up space on the screen and contributing to the count for notification_limit. (Commands to reproduce below with the minimal dunstrc)

Installation info

  • Version: 1.9.2-ed5bcb4
  • Install type: nixpkgs package overriden to use commit ed5bcb4.
  • Distro: NixOS
Minimal dunstrc and commands to reproduce
[custom_rule]
	msg_urgency = "critical"
	override_pause_level = 100
dunstctl set-paused true
dunstify -u critical one
dunstify -u normal two
@bynect
Copy link
Member

bynect commented Feb 28, 2024

You can set indicate_hidden = false to prevent this from happening

@bynect
Copy link
Member

bynect commented Feb 28, 2024

If however you want to still indicate the notifications with a bigger pause level if they exceed the notification_limit, I don't think it is possible at the moment

@SeerLite
Copy link
Contributor Author

I don't think indicate_hidden should be related to this. Otherwise there'd be an undismissable "(n more)" notification when paused and notifications are waiting. But currently there's nothing unless a notification above the pause level is received

@bynect
Copy link
Member

bynect commented Feb 29, 2024

If I am not mistaken this is how it works at the moment: We consider notification with a paused level under the threshold as hidden. Thus, the indicate_hidden option applies for displaying the number of hidden notification. This is similar to when the notification_limit is exceeded.

But your worries about an eternal xmore notification are totally right. From what I tested hidden notification don't expire and since they are hidden by a pause level they will never show up. So we have to make a change to accommodate this.

What do you think would be a reasonable solution to this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants