Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol and profile versions are not float #56

Open
xmedeko opened this issue Mar 7, 2018 · 1 comment · May be fixed by #135
Open

Protocol and profile versions are not float #56

xmedeko opened this issue Mar 7, 2018 · 1 comment · May be fixed by #135

Comments

@xmedeko
Copy link
Contributor

xmedeko commented Mar 7, 2018 •
edited
Loading

The FitFile.protocol_version, profile_version are just strings "major.minor" (i.e. "int dot int" format), not floats. Floats are inaccurate representations.
I propose to create a custom class FitVersion with fields major, minor and __str__ func with proper formatting. And maybe magic functions for comparison (__eq__, __gt__, ...). Can make a PR for that.
fundthmcalculus added a commit to fundthmcalculus/python-fitparse that referenced this issue Nov 1, 2021
@fundthmcalculus
FitVersion support to handle issue dtcooper#56
fc8bee8
@fundthmcalculus fundthmcalculus linked a pull request Nov 1, 2021 that will close this issue
Open
@fundthmcalculus
Copy link

PR to address this here: #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle FitFile versions without lossy float fundthmcalculus/python-fitparse
2 participants
@xmedeko @fundthmcalculus