Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for ICS Database 2020 #42

Closed
wants to merge 2 commits into from

Conversation

DesignrKnight
Copy link
Member

Link Types by Roll Number instead of Roll Number

Link Types by Roll Number instead of Roll Number
@DesignrKnight DesignrKnight self-assigned this Dec 10, 2020
@github-actions
Copy link

image image
Hello @DesignrKnight , That's a great improvement to the code. Have a pinch of paitence while the reviewer gets impressed by the changes you made. Here are some doggos for company while you are waiting for the merge and marching ahead with your Hacktoberfest Contributions, Check your Dashboard for more information on Hacktoberfest. Stay safe 🚀 .

@DesignrKnight
Copy link
Member Author

@DesignrKnight
Copy link
Member Author

image
image
image

@DesignrKnight
Copy link
Member Author

Approve when free @riteshsp2000
Do not merge yet. Will do once we are double sure after Astha finishes app part
This is already deployed to App Engine from localhost

@riteshsp2000
Copy link
Member

Hey @DesignrKnight, I checked all the queries... they are working great. But there are errors with coordinator mutations. The changes that you did for types, models ... those changes need to be done for mutations as well.

@DesignrKnight
Copy link
Member Author

Will do before merge

@github-actions
Copy link

image image
Hello @DesignrKnight , That's a great improvement to the code. Have a pinch of paitence while the reviewer gets impressed by the changes you made. Here are some doggos for company while you are waiting for the merge and marching ahead with your Hacktoberfest Contributions, Check your Dashboard for more information on Hacktoberfest. Stay safe 🚀 .

@abhibhaw
Copy link
Member

abhibhaw commented Oct 1, 2021

Wow PR opened since 2020 🎉 🎉

@abhibhaw
Copy link
Member

abhibhaw commented Dec 3, 2021

These changes have already been handled in the recent refactoring #60

@abhibhaw abhibhaw closed this Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flatten the coordinator model to have prefect is at same level as _id
3 participants