Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Required, final, trailing zero in 'SqlServerDsc' version numbers causing 're-publishing', version amendments #1451

Closed
SphenicPaul opened this issue Dec 27, 2019 · 4 comments
Labels
enhancement The issue is an enhancement request.

Comments

@SphenicPaul
Copy link
Contributor

At present, this SqlServerDsc, PowerShell module is consistently using a 4-part version (e.g. 13.2.0.0).

Unfortunately, when using the Microsoft-recommended approach to copying/duplicating/republishing a PowerShell module ...

https://docs.microsoft.com/en-us/powershell/scripting/gallery/how-to/working-with-local-psrepositories?view=powershell-6#publishing-to-a-local-repository

... the version of the SqlServerDsc module published to the local/internal repository omits the final zero (e.g. 13.2.0.0 becomes 13.2.0), presumably on the basis that this adds no/little value/meaning to the version of the module.

Seemingly, there are some aspects of PowerShellGet (and PowerShell, module management and dependency management) that treat 13.2.0.0 and 13.2.0 the same, and other areas that treat them as different values, so ensuring these are identical is important.

Is there any need for the SqlServerDsc, PowerShell module to be published to the public, PowerShell Gallery with the final zero? - Can the public, published version please be updated to a 3-part version (if the final part is going to be zero) to remove/reduce this down-stream, version adjustment problem (from future versions going forward) for anybody that may consume/reuse this module in their own, private, PowerShell repositories/galleries?

@johlju
Copy link
Member

johlju commented Dec 29, 2019

This issue has been discussed here PowerShell/DscResources#508. This repo will be moved to a new continuous delivery pipeline which will use semantic version. I'm currently working on it. When done, next release will use semantic versioning.

@johlju johlju added enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone. labels Dec 29, 2019
@SphenicPaul
Copy link
Contributor Author

@johlju
Copy link
Member

johlju commented Jan 2, 2020

A preview was just released to PowerShell Gallery which uses semantic version.
https://www.powershellgallery.com/packages/SqlServerDsc/13.3.0-preview0001

Full version will be released later, hoping to get in a few more PR's before releasing a new version.

@johlju
Copy link
Member

johlju commented Apr 25, 2020

This should be resolved now.

@johlju johlju closed this as completed Apr 25, 2020
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Development

No branches or pull requests

2 participants