Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label-schema.org labels are deprecated #208

Open
The-Loeki opened this issue Nov 6, 2018 · 3 comments
Open

label-schema.org labels are deprecated #208

The-Loeki opened this issue Nov 6, 2018 · 3 comments

Comments

@The-Loeki
Copy link

The label-schema.org labels are deprecated in favour of the Open Container Specification ones.
The builtin label-schema.org labels are therefore deprecated as well; I can hack up a PR, but we'd need to specify the behaviour regarding PLUGIN_LABELS and PLUGIN_CUSTOM_LABELS and not collide with #204 / #192 (where this was already discussed as well)

Related

Refs

@tboerger
Copy link

tboerger commented Nov 6, 2018

I'm not entirely sure if we just follow the new definition or if we just define some labels in the io.drone namespace similar to the build number mentioned in the above pull request.

@The-Loeki
Copy link
Author

well that seems a lot like the DRONE_ vs CI_ variables :)

I like having standarized ones as much as possible for my 5c, but as you mention in your thread, I'm not really sure where they are used (and thus may break if we'd change the label-schema.org ones for org.opencontainers ones)

@xoxys
Copy link

xoxys commented Dec 21, 2020

IMO there should be an option to disable the entire automatic label handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants