-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the func such as carbon.CreateFromDate()
.
#205
Comments
Thank you for your feedback, I will seriously consider it. |
If you need help, I'd be happy to provide it. |
If you don't want to change the name, then perhaps the notes should be written more clearly? Because as it stands now, the notes don't describe what the functions do very clearly. |
I also hesitated when I first named it, |
|
Currently can use the following methods |
I know that I can also use |
What should be the year, month and day in |
|
As you said, is it 0000-00-00 or currentYear-currentMonth-currentDay which is unknown to the user? |
Feature Request
Is your feature request related to a problem? Please describe:
When I use
carbon.CreateFromDate(2023,1,1)
, I think I will get the time2023-01-01 00:00:00
, but actually I get the time2023-01-01 Current Hour: Current Minutes: Current Seconds Current Nanoseconds
. I think this naming "CreateFromDate" is confusing and we should change it to something that describes its function more precisely, like " CreateFromDateUseCurrentHMS".Describe the feature you'd like:
Rename the func such as
carbon.CreateFromDate()
.Describe alternatives you've considered:
Yes, we can use
carbon.CreateFromDateTimeNano
,but for a new user,CreateFromDate
is still disorienting, which will cause unexpected bugs in their workTeachability, Documentation, Adoption, Migration Strategy:
With this renaming, users will know exactly what time they are using, and will not have a series of bugs caused by the use of this package, which can be implemented in a new version without affecting the old version of the code.
The text was updated successfully, but these errors were encountered: