Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection of Speedtest server should rely on Speedtest rather than IP whois lookup #179

Open
hrxcodes opened this issue Jun 26, 2020 · 0 comments
Milestone

Comments

@hrxcodes
Copy link
Contributor

Describe the feature

Selection of Speedtest server should rely on Speedtest rather than IP whois lookup.
There were some discussions on IRC how this should be handled bc users had slaves in environments where the neither the pasv_addr was set or in the config. This would only make sense in a testing scenario so not sure about the usecase here.

Either way the current evaluation of what server to use is over engineered.

Suggestion

As discussed on IRC we should instead query the service to tell us what the closest server is.
For example by using this api and speedtest wil tell us the closest server based on the egress IP information that Speedtest seems the connection from, no matter if the slave is on a CGNAT, NAT, local docker network or has a public external IP

@ghost ghost added the investigate label Jul 28, 2020
@ghost ghost added this to the 4.0.1-dev milestone Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant