Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Provide suggested parameter value instead of exiting VM #894

Open
ziyilin opened this issue Nov 26, 2024 · 0 comments
Open

[Misc] Provide suggested parameter value instead of exiting VM #894

ziyilin opened this issue Nov 26, 2024 · 0 comments

Comments

@ziyilin
Copy link
Collaborator

ziyilin commented Nov 26, 2024

Description
When user sets an invalid JVM option value, an error shall be reported and VM exits. This is good for most cases. But in automatically JVM option tuning scenario, JVM option is set by the auto tuning framework. If the input option is invalid, it's better to return a valid value so the auto tuning framework can continue to find a more proper option.
ziyilin added a commit to ziyilin/dragonwell11 that referenced this issue Nov 26, 2024
@ziyilin
[Misc] Return suggested value when violate option constraints
aa883b3 
Summary: Return suggested option value when it violates the constraints.
Exit the VM after all input options are checked.
Test: JTreg
Reviewers: Kuaiwei, wenjie
Issue: dragonwell-project#894
ziyilin added a commit to ziyilin/dragonwell11 that referenced this issue Nov 26, 2024
@ziyilin
[Misc] Return suggested value when violate option constraints
bda9bf3 
Summary: Return suggested option value when it violates the constraints.
Exit the VM after all input options are checked.
Test: JTreg
Reviewers: Kuaiwei, wenjie
Issue: dragonwell-project#894
ziyilin added a commit to ziyilin/dragonwell11 that referenced this issue Dec 5, 2024
@ziyilin
[Misc] Return suggested value when violate option constraints
b204782 
Summary: Return suggested option value when it violates the constraints.
Exit the VM after all input options are checked.
Testing: JTreg
Reviewers: Kuaiwei, wenjie
Issue: dragonwell-project#894
ziyilin added a commit to ziyilin/dragonwell11 that referenced this issue Dec 5, 2024
@ziyilin
[Misc] Return suggested value when violate option constraints
92d3bd5 
Summary: Return suggested option value when it violates the constraints.
Exit the VM after all input options are checked.
Testing: JTreg
Reviewers: Kuaiwei, wenjie
Issue: dragonwell-project#894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ziyilin