Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail when call to WithArguments provides more arguments that the resource/message expects #516

Open
Evangelink opened this issue Apr 27, 2020 · 1 comment · May be fixed by #1186
Open

Fail when call to WithArguments provides more arguments that the resource/message expects #516

Evangelink opened this issue Apr 27, 2020 · 1 comment · May be fixed by #1186
Labels
Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing help wanted

Comments

@Evangelink
Copy link
Member

Currently when your message has X format items and you call WithArguments with more than X arguments no issue is raised if the first X arguments match the expected. It would be nice if it was failing for extra parameters this way we could avoid regressions when the message suddenly uses less arguments.

From dotnet/roslyn-analyzers#3483 (comment)
@Evangelink Evangelink mentioned this issue Apr 27, 2020
Merged
@sharwell sharwell added Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing help wanted labels May 3, 2020
@sharwell
Copy link
Member

sharwell commented May 3, 2020

I hit this recently as well

@MattFromRVA MattFromRVA linked a pull request Aug 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WithArguments call validation MattFromRVA/roslyn-sdk
2 participants
@sharwell @Evangelink