Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install scripts don't attempt to install when the runtime specific binaries are present but not the dotnet executable #552

Open
JanProvaznik opened this issue Dec 4, 2024 · 1 comment
Labels
devkit-related enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Priority:3 triaged

Comments

@JanProvaznik
Copy link
Member

dotnet/vscode-dotnet-runtime#2059 (comment)

Install scripts could check that dotnet.exe / dotnet is present in the directory before deciding whether to install or report that it's already installed.

ls idir
LICENSE.txt  ThirdPartyNotices.txt  dotnet  host  shared
./dotnet-install.sh --install-dir idir/ --runtime aspnetcore
dotnet-install: ASP.NET Core Runtime with version '8.0.11' is already installed.

rm idir/dotnet
./dotnet-install.sh --install-dir idir/ --runtime aspnetcore
dotnet-install: ASP.NET Core Runtime with version '8.0.11' is already installed.

This change would enable a recovery from a corrupted install by using the same command again.

@JanProvaznik
Copy link
Member Author

Internal discussion:
Devkit can work around this faster if they need it (and install-scripts can't deploy this month if it's not critical).

There is no silver bullet for figuring out if the environment is set up correctly after the install scripts run and if a reinstall would help. But checking that the dotnet.exe/dotnet exists is a good idea with low priority.

@YuliiaKovalova YuliiaKovalova added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devkit-related enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Priority:3 triaged
Projects
None yet
Development

No branches or pull requests

2 participants