Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SqlConstantExpression obsolete constructor #35357

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

roji
Copy link
Member

@roji roji commented Dec 19, 2024

Forgoing a test since this fix is for an obsolete constructor that will go away soon anyway.

Fixes #35355

/cc @ranma42

@roji roji requested a review from a team as a code owner December 19, 2024 14:18
@roji roji requested a review from Copilot December 19, 2024 14:18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@ranma42
Copy link
Contributor

ranma42 commented Dec 19, 2024

Forgoing a test since this fix is for an obsolete constructor that will go away soon anyway.

If the API is going removed in EFCore 10.x, this change might make more sense as a minor fix to a 9.x.y (to ease the upgrade path by warning users while preserving the old behavior) than in the main branch... but I guess there is no need to hurry getting rid of the obsolete API if it is working 😉

Thank you for the immediate response!

@roji
Copy link
Member Author

roji commented Dec 19, 2024

We generally don't remove obsolete APIs in odd versions (short-term releases), since many users upgrade from LTS to LTS. So for someone upgrading from 8.0 to 10.0, obsoleting in 9.0 and removing in 10.0 would be a bit like immediate removal... But we'll most probably be removing this in 11.0.

@roji roji merged commit f163289 into dotnet:main Dec 20, 2024
7 checks passed
@roji roji deleted the SqlConstant branch December 20, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in the translation of SqlConstantExpression
3 participants