Global Query Filters filtering related entities

[hisuwh]

We are querying an entity and including an entity which has a global query filter. This entity is filtered out as consequence of this global query filter. This is either a bug or an undocumented feature but either way we need a workaround to this.

Steps to reproduce

Given this model:

class Author 
{
    public int Id { get; set; }
    public string Name { get; set; }
    public bool Archived { get; set; }
}

class BlogPost
{
    public int Id { get; set; }
    public string Title { get; set; }
    public int AuthorId { get; set; }
    public Author Author { get; set; }
}

class BlogContext
{
    public DbSet<Author> Authors { get; set; }
    public DbSet<BlogPost> BlogPosts { get; set; }

    protected override void OnModelCreating(ModelBuilder modelBuilder) 
    {
        modelBuilder.Entity<Author>()
             .HasQueryFilter(a => !a.Archived);
    }
}

I might have an API endpoint to return archived Authors and their posts.
Now say I call my API endpoint to return my blog post which is implemented like this:

public BlogPost Get(int id) {
    return this.context.BlogPosts
        .Include(b => b.Author)
        .SingleOrDefault(b => b.Id == id);
}

This returns null because it appears to be filtering out the BlogPost because its author is archived. Now I realise I could add .IgnoreGlobalFilters() here but I do not want to do this because this is my generic endpoint to return BlogPosts, and I might later add another Global Filter (i.e. !Deleted).

Possible Solutions

1. This needs documenting as it is not clear that this will happen currently
2. The behaviour is not the same if the relationship is optional (so int? AuthorId in the above example) - not sure if this is intended but this also needs documenting if so
3. We need a workaround

• this approach is not correct in all scenarios, I can see why you would want this for Deleted for example but it doesn't make sense in my case
• ideally this would be overridable on setup:

modelBuilder.Entity<Author>()
    .HasQueryFilter(a => !a.Archived, filterRelationships: false) // or a better name ;)

• worst case some way to ignore this when filtering:

return this.context.BlogPosts
        .Include(b => b.Author, ignoreGlobalFilters: true)
        .SingleOrDefault(b => b.Id == id);

Further technical details

EF Core version: 2.2.0
Database Provider: Microsoft.EntityFrameworkCore.SqlServer)
Operating system: Windows 10
IDE: isual Studio 2017 15.7.6

[smitpatel]

Duplicate of #11691

[hisuwh]

Sorry I did search for similar issues but did not come across that other one

[jonesty]

@hisuwh I know this is an old issue but what approach did you end up taking with this? I'm currently dealing with the same scenario. Cheers.

[hisuwh]

@jonesty I think we ended up not using global filters

[jonesty]

@hisuwh Thanks mate.