Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pipeline variable to reference MAR Status API resource/scope #1288

Open
lbussell opened this issue May 15, 2024 · 3 comments
Open

Use pipeline variable to reference MAR Status API resource/scope #1288

lbussell opened this issue May 15, 2024 · 3 comments

Comments

@lbussell
Copy link
Contributor

Currently we hardcode the resource scope for the MAR status API:

private const string McrStatusResource = "api://c00053c3-a979-4ee6-b94e-941881e62d8e";

This is very inflexible and requires changes to our source code if we need to change where this points to. Instead, we should accept a scope via the CLI and pass it in via an environment variable so that we can change it as needed without rebuilding ImageBuilder. We don't intend to frequently access this API on dev machines, so this should be an acceptable solution.

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@mthalman
Copy link
Member

It would probably make sense to define this in our Dotnet-Docker-Common variable group.

@lbussell lbussell moved this from Backlog to Current Release in .NET Docker May 16, 2024
@lbussell lbussell moved this from Current Release to Sprint in .NET Docker May 16, 2024
@lbussell lbussell moved this from Sprint to Current Release in .NET Docker Jun 3, 2024
@lbussell lbussell added the wave1 label Jun 6, 2024
@lbussell lbussell self-assigned this Aug 29, 2024
@lbussell lbussell moved this from Current Release to In Progress in .NET Docker Aug 29, 2024
@lbussell
Copy link
Contributor Author

There is a WIP branch for this here - https://github.com/lbussell/docker-tools/tree/issue-1288

@lbussell lbussell moved this from Current Release to Post Release in .NET Docker Sep 16, 2024
@lbussell lbussell moved this from Post Release to Current Release in .NET Docker Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Current Release
Development

No branches or pull requests

2 participants