From 6534a648cb442eca76b9ce762e631513efa563a2 Mon Sep 17 00:00:00 2001
From: tmat <tomas.matousek@microsoft.com>
Date: Thu, 20 Jun 2024 12:37:21 -0700
Subject: [PATCH 1/6] Flow NuGetPackageRoot out of Tools.proj restore

---
 .../tools/Build.proj                          | 22 ++++++++++++-------
 .../tools/Tools.proj                          |  2 ++
 2 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj b/src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj
index 11bc975dd42..6d9a43566fd 100644
--- a/src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj
+++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj
@@ -149,6 +149,20 @@
       <_RestoreToolsProps Include="DotNetPublishUsingPipelines=$(DotNetPublishUsingPipelines)"/>
     </ItemGroup>
 
+    <!--
+      Restore built-in tools.
+    -->
+    <MSBuild Projects="Tools.proj"
+             Targets="RestoreAndReturnNuGetPackageRoot"
+             Properties="@(_RestoreToolsProps);_NETCORE_ENGINEERING_TELEMETRY=Restore"
+             Condition="'$(Restore)' == 'true'">
+      <Output TaskParameter="TargetOutputs" ItemName="_RestoreToolsOutput" />
+    </MSBuild>
+
+    <ItemGroup Condition="'$(Restore)' == 'true'">
+      <_CommonProps Include="@(_RestoreToolsOutput->'NuGetPackageRoot=%(Identity)')"/>
+    </ItemGroup>
+
     <!--
       Builds from the 'internal' project, and only those, can download the .net Runtime 
       from a private location.
@@ -177,14 +191,6 @@
       <_SolutionBuildProps Include="__ImportPackTargets=true" Condition="'$(Pack)' == 'true'" />
     </ItemGroup>
 
-    <!--
-      Restore built-in tools.
-    -->
-    <MSBuild Projects="Tools.proj"
-             Targets="Restore"
-             Properties="@(_RestoreToolsProps);_NETCORE_ENGINEERING_TELEMETRY=Restore"
-             Condition="'$(Restore)' == 'true'"/>
-
     <!--
       Restore solutions and projects.
 
diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj b/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj
index 618af66f7d3..c9f11138485 100644
--- a/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj
+++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj
@@ -86,6 +86,8 @@
         Condition="'$(Restore)' == 'true'"/>
   </Target>
 
+  <Target Name="RestoreAndReturnNuGetPackageRoot" DependsOnTargets="Restore" Returns="$(NuGetPackageRoot)" />
+
   <Import Project="SourceBuild/SourceBuildArcadeTools.targets" Condition="'$(ArcadeBuildFromSource)' == 'true' or
                                                                           '$(DotNetBuildRepo)' == 'true' or
                                                                           '$(SetUpSourceBuildIntermediateNupkgCache)' == 'true'" />

From 28df9e50613fce5bd98920e29558f08df2edb562 Mon Sep 17 00:00:00 2001
From: Sam Harwell <Sam.Harwell@microsoft.com>
Date: Fri, 21 Jun 2024 08:34:59 -0500
Subject: [PATCH 2/6] Flow NuGetPackageRoot even on non-Restore paths

---
 .../tools/Build.proj                          | 32 +++++++++++--------
 .../tools/Tools.proj                          |  4 ++-
 2 files changed, 21 insertions(+), 15 deletions(-)

diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj b/src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj
index 6d9a43566fd..2778a3f3d24 100644
--- a/src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj
+++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj
@@ -133,7 +133,7 @@
       <_CommonProps Include="VCTargetsPath=$([MSBuild]::ValueOrDefault('$(VCTargetsPath)', '$([MSBuild]::GetVsInstallRoot())\Common7\IDE\VC\VCTargets\'))" Condition="'$(MSBuildRuntimeType)' != 'Core'"/>
     </ItemGroup>
 
-    <ItemGroup Condition="'$(Restore)' == 'true'">
+    <ItemGroup>
       <_RestoreToolsProps Include="@(_CommonProps)"/>
       <_RestoreToolsProps Include="BaseIntermediateOutputPath=$(ArtifactsToolsetDir)Common"/>
       <_RestoreToolsProps Include="ExcludeRestorePackageImports=true"/>
@@ -150,28 +150,32 @@
     </ItemGroup>
 
     <!--
-      Restore built-in tools.
+      Builds from the 'internal' project, and only those, can download the .net Runtime 
+      from a private location.
+    -->
+    <ItemGroup Condition="'$(SYSTEM_TEAMPROJECT)' == 'internal'">
+      <_RestoreToolsProps Include="DotNetRuntimeSourceFeed=$(DotNetRuntimeSourceFeed)"/>
+      <_RestoreToolsProps Include="DotNetRuntimeSourceFeedKey=$(DotNetRuntimeSourceFeedKey)"/>
+    </ItemGroup>
+
+    <!--
+      Restore built-in tools if requested, and extract information from the NuGet restore output.
     -->
     <MSBuild Projects="Tools.proj"
-             Targets="RestoreAndReturnNuGetPackageRoot"
+             Targets="Restore"
              Properties="@(_RestoreToolsProps);_NETCORE_ENGINEERING_TELEMETRY=Restore"
-             Condition="'$(Restore)' == 'true'">
+             Condition="'$(Restore)' == 'true'"/>
+
+    <MSBuild Projects="Tools.proj"
+             Targets="ReturnNuGetPackageRoot"
+             Properties="@(_RestoreToolsProps);_NETCORE_ENGINEERING_TELEMETRY=ReturnNuGetPackageRoot">
       <Output TaskParameter="TargetOutputs" ItemName="_RestoreToolsOutput" />
     </MSBuild>
 
-    <ItemGroup Condition="'$(Restore)' == 'true'">
+    <ItemGroup>
       <_CommonProps Include="@(_RestoreToolsOutput->'NuGetPackageRoot=%(Identity)')"/>
     </ItemGroup>
 
-    <!--
-      Builds from the 'internal' project, and only those, can download the .net Runtime 
-      from a private location.
-    -->
-    <ItemGroup Condition="'$(SYSTEM_TEAMPROJECT)' == 'internal'">
-      <_RestoreToolsProps Include="DotNetRuntimeSourceFeed=$(DotNetRuntimeSourceFeed)"/>
-      <_RestoreToolsProps Include="DotNetRuntimeSourceFeedKey=$(DotNetRuntimeSourceFeedKey)"/>
-    </ItemGroup>
-
     <ItemGroup>
       <_PublishProps Include="@(_CommonProps)"/>
 
diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj b/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj
index c9f11138485..1312bf079f3 100644
--- a/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj
+++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj
@@ -86,7 +86,9 @@
         Condition="'$(Restore)' == 'true'"/>
   </Target>
 
-  <Target Name="RestoreAndReturnNuGetPackageRoot" DependsOnTargets="Restore" Returns="$(NuGetPackageRoot)" />
+  <Target Name="ReturnNuGetPackageRoot" Returns="$(NuGetPackageRoot)">
+    <Error Text="Unable to determine 'NuGetPackageRoot' prior to restore." Condition="'$(NuGetPackageRoot)' == ''" />
+  </Target>
 
   <Import Project="SourceBuild/SourceBuildArcadeTools.targets" Condition="'$(ArcadeBuildFromSource)' == 'true' or
                                                                           '$(DotNetBuildRepo)' == 'true' or

From 5b27bb6e952e0ababfe039cab51232fd5dac3bc1 Mon Sep 17 00:00:00 2001
From: Sam Harwell <Sam.Harwell@microsoft.com>
Date: Mon, 24 Jun 2024 17:43:27 -0500
Subject: [PATCH 3/6] Use Microsoft.Build.Traversal for Tools.proj to import
 NuGet targets as expected

---
 .../tools/Build.proj                          | 24 +++++++++++--------
 .../tools/Tools.proj                          |  4 ++--
 2 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj b/src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj
index 2778a3f3d24..e6c0820a60a 100644
--- a/src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj
+++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj
@@ -134,19 +134,18 @@
     </ItemGroup>
 
     <ItemGroup>
-      <_RestoreToolsProps Include="@(_CommonProps)"/>
-      <_RestoreToolsProps Include="BaseIntermediateOutputPath=$(ArtifactsToolsetDir)Common"/>
-      <_RestoreToolsProps Include="ExcludeRestorePackageImports=true"/>
-      <_RestoreToolsProps Include="_NuGetRestoreTargets=$(_NuGetRestoreTargets)"/>
+      <_CommonToolsProps Include="@(_CommonProps)"/>
+      <_CommonToolsProps Include="BaseIntermediateOutputPath=$(ArtifactsToolsetDir)Common"/>
+      <_CommonToolsProps Include="_NuGetRestoreTargets=$(_NuGetRestoreTargets)"/>
       
       <!-- Used in the SDK (Tools.proj) to control whether Build.Tasks.Feed will be restored or not. -->
-      <_RestoreToolsProps Include="Publish=$(Publish)"/>
+      <_CommonToolsProps Include="Publish=$(Publish)"/>
 
       <!-- Used in the SDK (Tools.proj) to control whether SymbolUploader.Build.Task will be restored or not. -->
-      <_RestoreToolsProps Include="PublishToSymbolServer=$(PublishToSymbolServer)"/>
+      <_CommonToolsProps Include="PublishToSymbolServer=$(PublishToSymbolServer)"/>
 
       <!-- Forward this property because we can't assume it will be available globally. -->
-      <_RestoreToolsProps Include="DotNetPublishUsingPipelines=$(DotNetPublishUsingPipelines)"/>
+      <_CommonToolsProps Include="DotNetPublishUsingPipelines=$(DotNetPublishUsingPipelines)"/>
     </ItemGroup>
 
     <!--
@@ -154,8 +153,13 @@
       from a private location.
     -->
     <ItemGroup Condition="'$(SYSTEM_TEAMPROJECT)' == 'internal'">
-      <_RestoreToolsProps Include="DotNetRuntimeSourceFeed=$(DotNetRuntimeSourceFeed)"/>
-      <_RestoreToolsProps Include="DotNetRuntimeSourceFeedKey=$(DotNetRuntimeSourceFeedKey)"/>
+      <_CommonToolsProps Include="DotNetRuntimeSourceFeed=$(DotNetRuntimeSourceFeed)"/>
+      <_CommonToolsProps Include="DotNetRuntimeSourceFeedKey=$(DotNetRuntimeSourceFeedKey)"/>
+    </ItemGroup>
+
+    <ItemGroup>
+      <_RestoreToolsProps Include="@(_CommonToolsProps)"/>
+      <_RestoreToolsProps Include="ExcludeRestorePackageImports=true"/>
     </ItemGroup>
 
     <!--
@@ -168,7 +172,7 @@
 
     <MSBuild Projects="Tools.proj"
              Targets="ReturnNuGetPackageRoot"
-             Properties="@(_RestoreToolsProps);_NETCORE_ENGINEERING_TELEMETRY=ReturnNuGetPackageRoot">
+             Properties="@(_CommonToolsProps);_NETCORE_ENGINEERING_TELEMETRY=ReturnNuGetPackageRoot">
       <Output TaskParameter="TargetOutputs" ItemName="_RestoreToolsOutput" />
     </MSBuild>
 
diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj b/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj
index 1312bf079f3..06afec5d9ea 100644
--- a/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj
+++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj
@@ -1,5 +1,5 @@
 <!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. -->
-<Project>
+<Project Sdk="Microsoft.Build.Traversal">
 
   <Import Project="BuildStep.props" />
 
@@ -7,7 +7,7 @@
   <PropertyGroup>
     <TargetFramework>net472</TargetFramework>
     <!-- Workaround changes from newer MSBuild requiring additional properties --> 
-    <TargetFrameworkVersion Condition="'$(TargetFrameworkVersion)' == ''">5</TargetFrameworkVersion>
+    <TargetFrameworkVersion Condition="'$(TargetFrameworkVersion)' == ''">v4.7.2</TargetFrameworkVersion>
     <TargetFrameworkIdentifier  Condition="'$(TargetFrameworkIdentifier)' == ''">.NETFramework</TargetFrameworkIdentifier>
     <TargetFrameworkMoniker Condition="'$(TargetFrameworkMoniker)' == ''">.NETFramework,Version=v4.7.2</TargetFrameworkMoniker>   
     <MSBuildProjectExtensionsPath>$(BaseIntermediateOutputPath)</MSBuildProjectExtensionsPath>

From 50dd41dfebd58fc6b113a282bf8c855b5d1838bd Mon Sep 17 00:00:00 2001
From: Sam Harwell <Sam.Harwell@microsoft.com>
Date: Thu, 27 Jun 2024 08:49:54 -0500
Subject: [PATCH 4/6] Use Microsoft.Build.NoTargets instead of
 Microsoft.Build.Traversal

---
 src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj b/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj
index 06afec5d9ea..a91c51d519f 100644
--- a/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj
+++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj
@@ -1,5 +1,5 @@
 <!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. -->
-<Project Sdk="Microsoft.Build.Traversal">
+<Project Sdk="Microsoft.Build.NoTargets">
 
   <Import Project="BuildStep.props" />
 

From b7f3b9153c5d11af7110b065a8913378178b0cea Mon Sep 17 00:00:00 2001
From: Sam Harwell <Sam.Harwell@microsoft.com>
Date: Thu, 27 Jun 2024 17:33:27 -0500
Subject: [PATCH 5/6] Inline Microsoft.Build.NoTargets to avoid a reference to
 an external SDK

---
 ...56.DisableCopyFilesMarkedCopyLocal.targets |   4 +
 ...Microsoft.Build.NoTargets.3.7.56.Sdk.props |  80 +++++++++++++
 ...crosoft.Build.NoTargets.3.7.56.Sdk.targets | 106 ++++++++++++++++++
 .../tools/Tools.proj                          |   6 +-
 4 files changed, 195 insertions(+), 1 deletion(-)
 create mode 100644 src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.DisableCopyFilesMarkedCopyLocal.targets
 create mode 100644 src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.Sdk.props
 create mode 100644 src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.Sdk.targets

diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.DisableCopyFilesMarkedCopyLocal.targets b/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.DisableCopyFilesMarkedCopyLocal.targets
new file mode 100644
index 00000000000..6be7cc07bca
--- /dev/null
+++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.DisableCopyFilesMarkedCopyLocal.targets
@@ -0,0 +1,4 @@
+<Project>
+  <!-- Disables the _CopyFilesMarkedCopyLocal target by overriding it -->
+  <Target Name="_CopyFilesMarkedCopyLocal" />
+</Project>
\ No newline at end of file
diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.Sdk.props b/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.Sdk.props
new file mode 100644
index 00000000000..e1dc717defb
--- /dev/null
+++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.Sdk.props
@@ -0,0 +1,80 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+  Copyright (c) Microsoft Corporation. All rights reserved.
+  
+  Licensed under the MIT license.
+-->
+<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+
+  <PropertyGroup>
+    <UsingMicrosoftNoTargetsSdk>true</UsingMicrosoftNoTargetsSdk>
+    <MSBuildAllProjects Condition="'$(MSBuildToolsVersion)' != 'Current'">$(MSBuildAllProjects);$(MsBuildThisFileFullPath)</MSBuildAllProjects>
+  </PropertyGroup>
+
+  <PropertyGroup>
+    <!-- Copy logic to know if managed targets got imported: https://github.com/dotnet/sdk/blob/49002c14cf91ecd08e79d6184dbd4716c005b509/src/Tasks/Microsoft.NET.Build.Tasks/sdk/Sdk.targets#L25-L27 -->
+    <ManagedLanguageTargetsGotImported Condition="'$(MSBuildProjectExtension)' == '.csproj'">true</ManagedLanguageTargetsGotImported>
+    <ManagedLanguageTargetsGotImported Condition="'$(MSBuildProjectExtension)' == '.vbproj'">true</ManagedLanguageTargetsGotImported>
+    <ManagedLanguageTargetsGotImported Condition="'$(MSBuildProjectExtension)' == '.fsproj'">true</ManagedLanguageTargetsGotImported>
+  </PropertyGroup>
+
+  <Import Project="$(CustomBeforeNoTargetsProps)" Condition=" '$(CustomBeforeNoTargetsProps)' != '' And Exists('$(CustomBeforeNoTargetsProps)') " />
+
+  <PropertyGroup>
+    <!-- Disable default Compile and EmbeddedResource items for NoTargets projects -->
+    <EnableDefaultCompileItems>false</EnableDefaultCompileItems>
+    <EnableDefaultEmbeddedResourceItems>false</EnableDefaultEmbeddedResourceItems>
+
+    <!--
+      NuGet should always restore Traversal projects with "PackageReference" style restore.  Setting this property will cause the right thing to happen even if there aren't any PackageReference items in the project.
+    -->
+    <RestoreProjectStyle>PackageReference</RestoreProjectStyle>
+
+    <!-- Targeting packs shouldn't be referenced as traversal projects don't compile. -->
+    <DisableImplicitFrameworkReferences Condition="'$(DisableImplicitFrameworkReferences)' == ''">true</DisableImplicitFrameworkReferences>
+
+    <!-- Disable publish actions -->
+    <CopyBuildOutputToPublishDirectory Condition="'$(CopyBuildOutputToPublishDirectory)' == ''">false</CopyBuildOutputToPublishDirectory>
+    <CopyOutputSymbolsToPublishDirectory Condition="'$(CopyOutputSymbolsToPublishDirectory)' == ''">false</CopyOutputSymbolsToPublishDirectory>
+
+    <!-- Don't generate a deps file -->
+    <GenerateDependencyFile Condition="'$(GenerateDependencyFile)' == ''">false</GenerateDependencyFile>
+
+    <!-- Don't generate assembly info -->
+    <GenerateAssemblyInfo Condition="'$(GenerateAssemblyInfo)' == ''">false</GenerateAssemblyInfo>
+
+    <!-- Don't generate editor config file -->
+    <GenerateMSBuildEditorConfigFile Condition="'$(GenerateMSBuildEditorConfigFile)' == ''">false</GenerateMSBuildEditorConfigFile>
+    
+    <!-- Don't log the high priority message mentioning this project's name (or copy the product we didn't build). -->
+    <SkipCopyBuildProduct Condition="'$(SkipCopyBuildProduct)' == ''">true</SkipCopyBuildProduct>
+
+    <!-- Don't automatically reference assembly packages since NoTargets don't need reference assemblies -->
+    <AutomaticallyUseReferenceAssemblyPackages Condition="'$(AutomaticallyUseReferenceAssemblyPackages)' == ''">false</AutomaticallyUseReferenceAssemblyPackages>
+    <NoCompilerStandardLib Condition="'$(NoCompilerStandardLib)' == ''">false</NoCompilerStandardLib>
+    <NoStdLib Condition="'$(NoStdLib)' == ''">true</NoStdLib>
+    
+    <!-- Disable Visual Studio's Fast Up-to-date Check and rely on MSBuild to determine -->
+    <DisableFastUpToDateCheck Condition="'$(DisableFastUpToDateCheck)' == ''">true</DisableFastUpToDateCheck>
+  </PropertyGroup>
+
+  <ItemDefinitionGroup Condition=" '$(NoTargetsDoNotReferenceOutputAssemblies)' != 'false' ">
+    <ProjectReference>
+      <!--
+        Setting ReferenceOutputAssembly skips target framework cross-project validation in NuGet.  Since NoTargets projects don't define runtime
+        constraints like a target framework, there's no point in checking the compatibilty of project references.
+      -->
+      <ReferenceOutputAssembly>false</ReferenceOutputAssembly>
+      <SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties>
+    </ProjectReference>
+  </ItemDefinitionGroup>
+
+  <Target Name="CreateManifestResourceNames" />
+
+  <Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" Condition=" '$(MicrosoftCommonPropsHasBeenImported)' != 'true' "/>
+
+  <Import Project="$(CustomAfterNoTargetsProps)" Condition=" '$(CustomAfterNoTargetsProps)' != '' And Exists('$(CustomAfterNoTargetsProps)') " />
+
+  <!-- For CPS/VS support. Importing in .props allows any subsequent targets to redefine this if needed -->
+  <Target Name="CompileDesignTime" />
+</Project>
diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.Sdk.targets b/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.Sdk.targets
new file mode 100644
index 00000000000..a62a43a78f5
--- /dev/null
+++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.Sdk.targets
@@ -0,0 +1,106 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+  Copyright (c) Microsoft Corporation. All rights reserved.
+  
+  Licensed under the MIT license.
+-->
+<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+
+  <!--
+    Set LanguageTargets to Microsoft.Common.targets for any project that the SDK won't (.proj, .noproj, etc)
+    https://github.com/dotnet/sdk/blob/50ddfbb91be94d068514e8f4b0ce1052156364a0/src/Tasks/Microsoft.NET.Build.Tasks/sdk/Sdk.targets#L28
+    
+    We can't default LanguageTargets it is set in the SDK and immediately imported.  So we can only default
+    it if we know the SDK won't.  Projects probably won't load in Visual Studio but will build from the
+    command-line just fine.
+  -->
+  <PropertyGroup>
+    <LanguageTargets Condition=" '$(LanguageTargets)' == '' And '$(MSBuildProjectExtension)' != '.csproj' And '$(MSBuildProjectExtension)' != '.vbproj' And '$(MSBuildProjectExtension)' != '.fsproj' ">$(MSBuildToolsPath)\Microsoft.Common.targets</LanguageTargets>
+    <MSBuildAllProjects Condition="'$(MSBuildToolsVersion)' != 'Current'">$(MSBuildAllProjects);$(MsBuildThisFileFullPath)</MSBuildAllProjects>
+  </PropertyGroup>
+
+  <Import Project="$(CustomBeforeNoTargets)" Condition="'$(CustomBeforeNoTargets)' != '' and Exists('$(CustomBeforeNoTargets)')" />
+
+  <PropertyGroup>
+    <!-- Don't include build output in a package since NoTargets projects don't emit an assembly. -->
+    <IncludeBuildOutput Condition="'$(IncludeBuildOutput)' == ''">false</IncludeBuildOutput>
+
+    <!-- For CPS/VS support. See https://github.com/dotnet/project-system/blob/master/src/Microsoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/DesignTimeTargets/Microsoft.Managed.DesignTime.targets#L60 -->
+    <CustomBeforeMicrosoftCommonTargets Condition="'$(ManagedLanguageTargetsGotImported)' == '' And Exists('$(MSBuildExtensionsPath)\Microsoft\VisualStudio\Managed\Microsoft.Managed.DesignTime.targets')">$(CustomBeforeMicrosoftCommonTargets);$(MSBuildExtensionsPath)\Microsoft\VisualStudio\Managed\Microsoft.Managed.DesignTime.targets</CustomBeforeMicrosoftCommonTargets>
+  </PropertyGroup>
+
+  <Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk" Condition=" '$(CommonTargetsPath)' == '' " />
+
+  <PropertyGroup>
+    <!-- This property must be overridden to remove a few targets that compile assemblies -->
+    <CoreBuildDependsOn>
+      BuildOnlySettings;
+      PrepareForBuild;
+      PreBuildEvent;
+      ResolveReferences;
+      Compile;
+      GetTargetPath;
+      PrepareForRun;
+      IncrementalClean;
+      PostBuildEvent
+    </CoreBuildDependsOn>
+    
+    <!-- Disable symbol generation -->
+    <DebugType>None</DebugType>
+    <DebugSymbols>false</DebugSymbols>
+    
+    <!-- Don't emit a reference assembly -->
+    <ProduceReferenceAssembly>false</ProduceReferenceAssembly>
+  </PropertyGroup>
+
+  <!-- Clear output group items which are read by the IDE and NuGet. -->
+  <ItemGroup>
+    <BuiltProjectOutputGroupKeyOutput Remove="@(BuiltProjectOutputGroupKeyOutput)" />
+    <DebugSymbolsProjectOutputGroupOutput Remove="@(DebugSymbolsProjectOutputGroupOutput)" />
+    <IntermediateAssembly Remove="@(IntermediateAssembly)" />
+    <IntermediateRefAssembly Remove="@(IntermediateRefAssembly)" />
+    <Reference Remove="mscorlib" />
+  </ItemGroup>
+
+  <!--
+    The CopyFilesToOutputDirectory target is hard coded to depend on ComputeIntermediateSatelliteAssemblies.  NoTargets projects do no generate resource assemblies
+    so the target is replaced with a no-op
+  -->
+  <Target Name="ComputeIntermediateSatelliteAssemblies" />
+
+  <!--
+    NoTargets projects do not build an assembly so dependent projects shouldn't get a path to the target.  Override the GetTargetPath to do nothing.
+  -->
+  <Target Name="GetTargetPath" />
+
+  <!--
+    The GetTargetPathWithTargetPlatformMoniker target uses a BeforeTargets so the only way to disable it is to override it with an empty target.
+  -->
+  <Target Name="GetTargetPathWithTargetPlatformMoniker" />
+
+  <!--
+    The GetReferenceAssemblyPaths does not need to run since reference assemblies aren't needed.
+  -->
+  <Target Name="GetFrameworkPaths" DependsOnTargets="$(GetFrameworkPathsDependsOn)" />
+  <Target Name="GetReferenceAssemblyPaths" DependsOnTargets="$(GetReferenceAssemblyPathsDependsOn)" />
+
+  <Import Project="$(CustomAfterNoTargets)" Condition="'$(CustomAfterNoTargets)' != '' and Exists('$(CustomAfterNoTargets)')" />
+
+  <!-- 
+    Microsoft.Managed.Targets is imported by the managed language target files in MSBuild 16.0 and above, but most of the msbuild tasks are actually in Microsoft.Common.Currentversion.targets.
+    So import it when the managed targets do not get imported.
+  -->
+  <Import Project="$(MSBuildToolsPath)\Microsoft.Managed.targets" Condition="'$(MSBuildAssemblyVersion)' >= '16.0' And '$(ManagedLanguageTargetsGotImported)' != 'true'" />
+
+  <!-- Override stock CoreCompile target to do nothing but keep extensibility points -->
+  <Target Name="CoreCompile"
+          DependsOnTargets="$(CoreCompileDependsOn)">
+    <CallTarget Targets="$(TargetsTriggeredByCompilation)" Condition="'$(TargetsTriggeredByCompilation)' != ''" />
+  </Target>
+
+  <Target Name="_GenerateCompileInputs" />
+  <Target Name="_GenerateCompileDependencyCache" />
+
+  <!-- Disables the _CopyFilesMarkedCopyLocal target to not copy references when SkipCopyFilesMarkedCopyLocal is set to false. -->
+  <Import Project="Microsoft.Build.NoTargets.3.7.56.DisableCopyFilesMarkedCopyLocal.targets" Condition="'$(SkipCopyFilesMarkedCopyLocal)' == 'true'" />
+</Project>
diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj b/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj
index a91c51d519f..438065e41c5 100644
--- a/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj
+++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj
@@ -1,5 +1,7 @@
 <!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. -->
-<Project Sdk="Microsoft.Build.NoTargets">
+<Project>
+
+  <Import Project="Microsoft.Build.NoTargets.3.7.56.Sdk.props"/>
 
   <Import Project="BuildStep.props" />
 
@@ -101,4 +103,6 @@
 
   <Import Project="VisualStudio.AcquireOptimizationData.targets" Condition="'$(UsingToolVisualStudioIbcTraining)' == 'true'" />
 
+  <Import Project="Microsoft.Build.NoTargets.3.7.56.Sdk.targets"/>
+
 </Project>

From 85fba110828a504eb39750d19504f1b28db00a2b Mon Sep 17 00:00:00 2001
From: Sam Harwell <Sam.Harwell@microsoft.com>
Date: Wed, 3 Jul 2024 13:27:45 -0500
Subject: [PATCH 6/6] Add attribution notice

---
 ...ld.NoTargets.3.7.56.DisableCopyFilesMarkedCopyLocal.targets | 3 ++-
 .../tools/Microsoft.Build.NoTargets.3.7.56.Sdk.props           | 1 +
 .../tools/Microsoft.Build.NoTargets.3.7.56.Sdk.targets         | 3 ++-
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.DisableCopyFilesMarkedCopyLocal.targets b/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.DisableCopyFilesMarkedCopyLocal.targets
index 6be7cc07bca..86e95ca1b14 100644
--- a/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.DisableCopyFilesMarkedCopyLocal.targets
+++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.DisableCopyFilesMarkedCopyLocal.targets
@@ -1,4 +1,5 @@
+<!-- Sourced from NuGet package Microsoft.Build.NoTargets -->
 <Project>
   <!-- Disables the _CopyFilesMarkedCopyLocal target by overriding it -->
   <Target Name="_CopyFilesMarkedCopyLocal" />
-</Project>
\ No newline at end of file
+</Project>
diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.Sdk.props b/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.Sdk.props
index e1dc717defb..945ada3e5d2 100644
--- a/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.Sdk.props
+++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.Sdk.props
@@ -4,6 +4,7 @@
   
   Licensed under the MIT license.
 -->
+<!-- Sourced from NuGet package Microsoft.Build.NoTargets -->
 <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
 
   <PropertyGroup>
diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.Sdk.targets b/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.Sdk.targets
index a62a43a78f5..94ea814bf1e 100644
--- a/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.Sdk.targets
+++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/Microsoft.Build.NoTargets.3.7.56.Sdk.targets
@@ -1,9 +1,10 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <!--
   Copyright (c) Microsoft Corporation. All rights reserved.
   
   Licensed under the MIT license.
 -->
+<!-- Sourced from NuGet package Microsoft.Build.NoTargets -->
 <Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
 
   <!--