Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout failure: "Git fetch failed with exit code 128" #9009

Open
2 tasks
carlossanlop opened this issue Apr 8, 2022 · 14 comments
Open
2 tasks

Checkout failure: "Git fetch failed with exit code 128" #9009

carlossanlop opened this issue Apr 8, 2022 · 14 comments
Labels
Known Build Error Ops - Facilely Operations issues that are easily accomplished or attained

Comments

@carlossanlop
Copy link
Member

carlossanlop commented Apr 8, 2022

Build

https://dev.azure.com/dnceng/public/_build/results?buildId=1706886&view=results

Build leg reported

Libraries Test Run release coreclr Linux_musl x64 Release

Pull Request

Rolling build for runtime

Action required for the engineering services team

To triage this issue (First Responder / @dotnet/dnceng):

  • Open the failing build above and investigate
  • Add a comment explaining your findings

If this is an issue that is causing build breaks across multiple builds and would get benefit from being listed on the build analysis check, follow the next steps:

  1. Add the label "Known Build Error"
  2. Edit this issue and add an error string in the Json below that can help us match this issue with future build breaks. You should use the known issues documentation
{
   "ErrorMessage" : "Git fetch failed with exit code: 128",
   "BuildRetry": true
}

Additional information about the issue reported

The Checkout dotnet/runtime@main to s step is the one that failed. Here is the end of the log output:

remote: Compressing objects:  29% (30070/103687)        
remote: Compressing objects:  30% (31107/103687)        
remote: Compressing objects:  31% (32143/103687)        
remote: Compressing objects:  31% (32322/103687)        
remote: Compressing objects:  32% (33180/103687)        
remote: Compressing objects:  33% (34217/103687)        
remote: Compressing objects:  33% (35247/103687)        
remote: Compressing objects:  34% (35254/103687)        
remote: Compressing objects:  35% (36291/103687)        
remote: Compressing objects:  36% (37328/103687)        
remote: Compressing objects:  37% (38365/103687)        
remote: Compressing objects:  37% (38926/103687)        
remote: Compressing objects:  38% (39402/103687)        
error: RPC failed; curl 18 transfer closed with outstanding read data remaining
fatal: protocol error: bad pack header
##[error]Git fetch failed with exit code: 128
Finishing: Checkout dotnet/runtime@main to s

Report

Build Definition Step Name Console log Pull Request
902482 dotnet/sdk Checkout dotnet/sdk@refs/pull/45485/merge to s Log dotnet/sdk#45485
902244 dotnet/roslyn Checkout dotnet/roslyn@main to s Log
2605819 dotnet-runtime Checkout dotnet-runtime@release/9.0-staging to s Log
900702 dotnet/sdk Checkout dotnet/sdk@refs/pull/45591/merge to s Log dotnet/sdk#45591
900694 dotnet/sdk Clone dotnet/sdk Log dotnet/sdk#45590
900649 dotnet/runtime Checkout dotnet/runtime@refs/pull/110849/merge to s Log dotnet/runtime#110849
900695 dotnet/sdk Checkout dotnet/sdk@refs/pull/45590/merge to s Log dotnet/sdk#45590
900697 dotnet/sdk Clone dotnet/sdk Log dotnet/sdk#45590
900532 dotnet/sdk Checkout dotnet/sdk@refs/pull/45585/merge to s Log dotnet/sdk#45585
900529 dotnet/sdk Clone dotnet/sdk Log dotnet/sdk#45585
900533 dotnet/sdk Clone dotnet/sdk Log dotnet/sdk#45585
900452 dotnet/arcade-services Checkout dotnet/arcade-services@refs/pull/4270/merge to s Log dotnet/arcade-services#4270
900109 dotnet/runtime Checkout dotnet/runtime@refs/pull/110844/merge to s Log dotnet/runtime#110844
898987 dotnet/runtime Checkout dotnet/runtime@refs/pull/110816/merge to s Log dotnet/runtime#110816
898199 dotnet/runtime Checkout dotnet/runtime@refs/pull/110797/merge to s Log dotnet/runtime#110797
898177 dotnet/runtime Checkout dotnet/runtime@refs/pull/110787/merge to s Log dotnet/runtime#110787
897513 dotnet/sdk Checkout dotnet/sdk@refs/pull/45492/merge to s Log dotnet/sdk#45492
897697 dotnet/runtime Checkout dotnet/runtime@refs/pull/110630/merge to s Log dotnet/runtime#110630
894764 dotnet/runtime Checkout dotnet/runtime@refs/pull/110694/merge to s Log dotnet/runtime#110694
894484 dotnet/runtime Checkout dotnet/runtime@refs/pull/110682/merge to s Log dotnet/runtime#110682
894251 dotnet/runtime Checkout dotnet/runtime@refs/pull/110635/merge to s Log dotnet/runtime#110635
892498 maestro-auth-test/helix-queue-insights-test Checkout maestro-auth-test/helix-queue-insights-test@refs/pull/826/merge to s Log maestro-auth-test/helix-queue-insights-test#826
891771 maestro-auth-test/helix-queue-insights-test Checkout maestro-auth-test/helix-queue-insights-test@refs/pull/823/merge to s Log maestro-auth-test/helix-queue-insights-test#823
891750 maestro-auth-test/helix-queue-insights-test Checkout maestro-auth-test/helix-queue-insights-test@refs/pull/821/merge to s Log maestro-auth-test/helix-queue-insights-test#821
891704 maestro-auth-test/helix-queue-insights-test Checkout maestro-auth-test/helix-queue-insights-test@refs/pull/819/merge to s Log maestro-auth-test/helix-queue-insights-test#819
891506 maestro-auth-test/helix-queue-insights-test Checkout maestro-auth-test/helix-queue-insights-test@refs/pull/815/merge to s Log maestro-auth-test/helix-queue-insights-test#815
891330 dotnet/arcade-services Checkout dotnet/arcade-services@refs/pull/4234/merge to s Log dotnet/arcade-services#4234
890834 dotnet/sdk Clone dotnet/sdk Log dotnet/sdk#45371
890835 dotnet/sdk Checkout dotnet/sdk@refs/pull/45371/merge to s Log dotnet/sdk#45371
890836 dotnet/sdk Clone dotnet/sdk Log dotnet/sdk#45371
889763 dotnet/sdk Clone dotnet/sdk Log dotnet/sdk#45371
889764 dotnet/sdk Checkout dotnet/sdk@refs/pull/45371/merge to s Log dotnet/sdk#45371
890663 dotnet/runtime Checkout dotnet/runtime@refs/pull/110465/merge to s Log dotnet/runtime#110465
889765 dotnet/sdk Clone dotnet/sdk Log dotnet/sdk#45371
889746 dotnet/sdk Clone dotnet/sdk Log dotnet/sdk#45371
889744 dotnet/sdk Clone dotnet/sdk Log dotnet/sdk#45371
887492 dotnet/runtime Checkout dotnet/runtime@refs/pull/109320/merge to s Log dotnet/runtime#109320
886459 dotnet/roslyn Checkout dotnet/roslyn@main to s Log
886449 dotnet/sdk Clone dotnet/dotnet Log dotnet/sdk#41268
886428 dotnet/runtime Checkout dotnet/runtime@refs/pull/107743/merge to s Log dotnet/runtime#107743
886429 dotnet/runtime Checkout dotnet/runtime@refs/pull/107743/merge to s Log dotnet/runtime#107743
886424 dotnet/runtime Checkout dotnet/runtime@refs/pull/110408/merge to s Log dotnet/runtime#110408
886435 dotnet/runtime Checkout dotnet/runtime@refs/pull/110404/merge to s Log dotnet/runtime#110404
886361 dotnet/runtime Checkout dotnet/runtime@refs/pull/109754/merge to s Log dotnet/runtime#109754
2594635 dotnet-aspnetcore Checkout dotnet-aspnetcore@refs/pull/45643/merge to s Log #45643
886306 dotnet/arcade-services Checkout dotnet/arcade-services@refs/pull/4212/merge to s Log dotnet/arcade-services#4212
886148 dotnet/sdk Clone dotnet/sdk Log dotnet/sdk#45252
885682 maestro-auth-test/helix-queue-insights-test Checkout maestro-auth-test/helix-queue-insights-test@refs/pull/795/merge to s Log maestro-auth-test/helix-queue-insights-test#795
885647 maestro-auth-test/helix-queue-insights-test Checkout maestro-auth-test/helix-queue-insights-test@refs/pull/794/merge to s Log maestro-auth-test/helix-queue-insights-test#794
885484 maestro-auth-test/helix-queue-insights-test Checkout maestro-auth-test/helix-queue-insights-test@refs/pull/793/merge to s Log maestro-auth-test/helix-queue-insights-test#793
885321 dotnet/runtime Checkout dotnet/runtime@refs/pull/110370/merge to s Log dotnet/runtime#110370
885286 dotnet/runtime Checkout dotnet/runtime@refs/pull/109308/merge to s Log dotnet/runtime#109308
885276 dotnet/runtime Checkout dotnet/runtime@refs/pull/109336/merge to s Log dotnet/runtime#109336
885273 dotnet/runtime Checkout dotnet/runtime@refs/pull/109298/merge to s Log dotnet/runtime#109298
884978 dotnet/arcade-services Checkout dotnet/arcade-services@refs/pull/4209/merge to s Log dotnet/arcade-services#4209
884270 dotnet/runtime Checkout dotnet/runtime@refs/pull/109566/merge to s Log dotnet/runtime#109566
884259 dotnet/runtime Checkout dotnet/runtime@refs/pull/109045/merge to s Log dotnet/runtime#109045
884264 dotnet/runtime Checkout dotnet/runtime@refs/pull/108970/merge to s Log dotnet/runtime#108970
884266 dotnet/runtime Checkout dotnet/runtime@refs/pull/110329/merge to s Log dotnet/runtime#110329
884045 dotnet/installer Clone dotnet/installer Log dotnet/installer#20254
883899 dotnet/sdk Clone dotnet/sdk Log dotnet/sdk#45123
883897 dotnet/sdk Clone dotnet/sdk Log dotnet/sdk#45123
883898 dotnet/sdk Checkout dotnet/sdk@refs/pull/45123/merge to s Log dotnet/sdk#45123
881904 dotnet/runtime Checkout dotnet/runtime@refs/pull/110246/merge to s Log dotnet/runtime#110246
880764 dotnet/sdk Clone dotnet/sdk Log dotnet/sdk#45162
880982 dotnet/sdk Clone dotnet/sdk Log dotnet/sdk#45189
880320 dotnet/runtime Checkout dotnet/runtime@refs/pull/110207/merge to s Log dotnet/runtime#110207

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 13 67

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=323960
Error message validated: Git fetch failed with exit code: 128
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 6/28/2023 9:15:14 PM UTC

@ChadNedzlek
Copy link
Member

So this is... interesting. I agree this seems like essentially a random network failure that is not the fault of the code. Also... it doesn't seem like there is anything to be done other than retry the build.

@ulisesh and @AlitzelMendez. This seems like another instance of a "known issue" that would really benefit from the ability to get retried automatically. I think Carlos did the right thing by opening the known issue, but his PR (and any future PR that hits this) is still going to be blocked, since the build doesn't run at all in this case, because the checkout failed. And it would be great to help folks that hit this.

@ulisesh
Copy link
Contributor

ulisesh commented Apr 13, 2022

I created the issue to track how often it was happening and measure the impact of the problem. It might be hard to get traction on networking problems but having the number of impacted builds has great value in my opinion.

In the last 24 hours, we had 37 builds failed with the same error. cc @markwilkie who might find this data interesting.

I think automatic retries for known issues will be the next feature after we are done with analyzing builds retroactively, we can discuss this if people think we should change priorities.

@markwilkie
Copy link
Member

So 37 builds were caught with the known issues feature @ulisesh ? Could I get the query please? (super exciting)

@ulisesh
Copy link
Contributor

ulisesh commented Apr 13, 2022

I saw 37 hits in the office but now I only see 33 🤔. There are 33 failed jobs in 2 different builds. Sorry if I misused the terms but I still think it is great that we can track these build breaks 😄

This is the query:

KnownIssues
| where IssueId == 9009 and IssueRepository == "dotnet/arcade"

@ilyas1974 ilyas1974 self-assigned this Apr 19, 2022
@ilyas1974 ilyas1974 removed their assignment Jun 22, 2022
@ilyas1974 ilyas1974 removed Ops - First Responder Detected By - Customer Issue was reported by a customer labels Jun 22, 2022
@danmoseley danmoseley changed the title Checkout dotnet/runtime step failure: "Git fetch failed with exit code 128" Checkout failure: "Git fetch failed with exit code 128" Oct 7, 2022
@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 11, 2023

This happened 36 times in the last 24 hours. Should we add a retry (assuming that's possible)?

@premun
Copy link
Member

premun commented Jan 11, 2023

GitHub reported degraded git operations yesterday: https://www.githubstatus.com/incidents/00km0kwpz23b
We saw problems cloning all over. Maybe it's related to that?

@dougbu
Copy link
Member

dougbu commented Jan 8, 2024

This issue may have started in early 2022 but seems to remain w/ 29 matching failures in the last 24 hours. https://www.githubstatus.com/ and various Azure / Azure DevOps status pages aren't showing any current or recent degradations. Unclear what's going on this time beyond what appears to be DNS flakiness. I looked at the last 7 reports; all but one showed fatal: unable to access 'https://github.com/dotnet/runtime/': Could not resolve host: github.com and a few also showed fatal: unable to access 'https://github.com/dotnet/runtime/': Failed to connect to github.com port 443 after 75012 ms: Couldn't connect to server.

Without more information, I think the best we could do is auto retry when the problem occurs. @AlitzelMendez and @carlossanlop what are your thoughts on including "BuildRetry": true in the JSON content in this description❔

@carlossanlop
Copy link
Member Author

It's fine, we can try that, as long as we monitor it closely, because if we keep seeing the failure even with a retry, I think we should just go back to "BuildRetry": false, to avoid wasting resources.

@dougbu
Copy link
Member

dougbu commented Jan 8, 2024

you mean "BuildRetry": true was tried in the past and didn't help much @carlossanlop❔ if the extra time it takes PR creators to click the Rerun failed builds actually helps avoid issues in the retry, I'd lean toward leaving things as-is.

@carlossanlop
Copy link
Member Author

I do not know if it was tried in the past.

@AlitzelMendez
Copy link
Member

sounds like a good plan @dougbu, let's try "BuildRetry": true, I will put together a query to monitor if it is helpful for this issue

@dougbu
Copy link
Member

dougbu commented Jan 8, 2024

updated the description to try retries

@AlitzelMendez
Copy link
Member

query:

let buildIds =
KnownIssues
| where ingestion_time() > datetime(2024-01-08 23:10:44.8683418)
| where IssueId  == 9009
| distinct BuildId;
TimelineBuilds
| where BuildId  in (buildIds)
| summarize arg_max(FinishTime, *) by BuildId
| summarize count() by Result, bin(FinishTime, 1d)
| order by FinishTime asc 
| render columnchart with (xcolumn=FinishTime)

I will check this on Monday to see how it is going, posting here the query so I don't loose it :)

@AlitzelMendez
Copy link
Member

the success rate (having a green build) after the retry was between 30% to 50% per day, so this doesn't solve the issue, it just helps to mitigate it a little bit.

@AlitzelMendez AlitzelMendez removed their assignment Jan 16, 2024
@ilyas1974 ilyas1974 added the Ops - Facilely Operations issues that are easily accomplished or attained label Feb 21, 2024
@garath garath added the Ops - P2 Operations task, priority 2 label Mar 28, 2024
@ilyas1974 ilyas1974 removed the Ops - P2 Operations task, priority 2 label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Known Build Error Ops - Facilely Operations issues that are easily accomplished or attained
Projects
None yet
Development

No branches or pull requests

10 participants