Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle CLI args containing quoted elements with spaces properly in powershell functions #15339

Open
jwosty opened this issue Dec 16, 2024 · 0 comments

Comments

@jwosty
Copy link

jwosty commented Dec 16, 2024

In particular, I believe that https://github.com/dotnet/arcade/blob/main/eng/common/tools.ps1#L85 is somehow not handling quoted variables with spaces correctly. See: dotnet/fsharp#18143. In that PR, I've fixed some of the other space-handling issues in the F# build scripts, and when debugging it seems to pass $commandArgs correctly (with paths quoted) but the output indicates that MSBuild is still not getting the correct parameters.

To repro, clone that PR into a directory with spaces, then run .\build.cmd (which should succeed) and then .\build.cmd -testCambridge -c Release -ci -nobl (which will fail)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant