Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid failing when GuardianConfiguration artifact already exists #14527

Closed
1 of 2 tasks
jjonescz opened this issue Feb 29, 2024 · 4 comments · May be fixed by #14528
Closed
1 of 2 tasks

Avoid failing when GuardianConfiguration artifact already exists #14527

jjonescz opened this issue Feb 29, 2024 · 4 comments · May be fixed by #14528

Comments

@jjonescz
Copy link
Member

  • This issue is blocking
  • This issue is causing unreasonable pain

When I rerun roslyn official build after for example "Execute SDL" step fails, the re-run can never succeed since the "Publish GuardianConfiguration" will always report "##[error]Artifact GuardianConfiguration already exists for build 2390566."

Recent example

So I have to start a completely new official build which takes 2 hours.

Can we instead make the "Publish GuardianConfiguration" step optional so the pipeline continues even if the artifact exists? (Or delete/overwrite the previous artifact?) I don't know what the Guardian here is, but it doesn't seem crucial for the build to continue.

@dougbu
Copy link
Member

dougbu commented Mar 21, 2024

@jjonescz does this issue remain in branches that have migrated to use the 1ES pipeline templates❔ I am wondering whether SDL support in dotnet/arcade should be removed soon after the migrations wrap.

@jjonescz
Copy link
Member Author

You're right. The SDL step is currently disabled/skipped in 1ES templates, so the issue doesn't occur there, or at least not in SDL step, but it might occur in other steps where artifacts are uploaded similarly (during migration I have tried rerunning the pipeline at various stages and it often failed with similar error although I haven't investigated more deeply). Also I think the SDL step should be re-enabled, see internal thread.

@missymessa
Copy link
Member

SDL scans should be used in conjunction with the Official 1ES PT. We will be removing SDL from Arcade as not to duplicate efforts between Arcade and 1ES PT.

Please reach out to 1ES PT support channel if you need help with it. https://teams.microsoft.com/l/channel/19%3A6d24d44587aa4d868bd4e96fe0eead31%40thread.tacv2/Support%20-%20General?groupId=886b1d22-e648-4492-af5f-6fbe81e73d4a&tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47

@missymessa
Copy link
Member

1ES PT conversions should be completed. SDL is not injected into pipelines via Arcade. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants