Use ArtifactsPath #2676
Open
Use ArtifactsPath #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
timcassell
force-pushed
the
fix-intermediateoutputpath
branch
from
e20dd82 to
6c5a4e5
Compare
Pass PublishDir property to dotnet.
timcassell
force-pushed
the
fix-intermediateoutputpath
branch
from
6c5a4e5 to
fb9c47a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2425
Fixes #2664
We set
ArtifactsPathif the dotnet sdk used supports it (v8.0 or higher). Older sdks still use the same build logic as previous, and as far as I could find out, it's the best we can do for those older sdks.Passing
ArtifactsPathalso makes MSBuild output publish directory differently by default, so we passPublishDiralso to work for both old and new sdks.