Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BenchmarkDotNet crashing on Linux with DisassemblyDiagnoser #2070

Closed
MichalPetryka opened this issue Aug 3, 2022 · 9 comments · Fixed by #2092
Closed

BenchmarkDotNet crashing on Linux with DisassemblyDiagnoser #2070

MichalPetryka opened this issue Aug 3, 2022 · 9 comments · Fixed by #2092
Assignees
Milestone

Comments

@MichalPetryka
Copy link
Contributor

MichalPetryka commented Aug 3, 2022

Opening as per #2000 (comment).

My configuration is:
Kubuntu 20.04
and the provided commands return:

xterm-256color


pl_PL.UTF-8

(the middle ones don't return anything)

@MichalPetryka
Copy link
Contributor Author

locale returns:

LANG=pl_PL.UTF-8
LANGUAGE=pl:en_US
LC_CTYPE="pl_PL.UTF-8"
LC_NUMERIC="pl_PL.UTF-8"
LC_TIME="pl_PL.UTF-8"
LC_COLLATE="pl_PL.UTF-8"
LC_MONETARY="pl_PL.UTF-8"
LC_MESSAGES="pl_PL.UTF-8"
LC_PAPER="pl_PL.UTF-8"
LC_NAME="pl_PL.UTF-8"
LC_ADDRESS="pl_PL.UTF-8"
LC_TELEPHONE="pl_PL.UTF-8"
LC_MEASUREMENT="pl_PL.UTF-8"
LC_IDENTIFICATION="pl_PL.UTF-8"
LC_ALL=

@adamsitnik
Copy link
Member

@MichalPetryka the issue should got fixed with #2092. Could you please try 0.13.2.1892 and see if it did?

<packageSources>
  <add key="bdn-ci" value="https://ci.appveyor.com/nuget/benchmarkdotnet" />
</packageSources>

@adamsitnik
Copy link
Member

@bartonjs can still reproduce it

@adamsitnik adamsitnik reopened this Sep 22, 2022
@adamsitnik
Copy link
Member

The issue was partially resolved by @janvorli in #2123

@janvorli has identified a bug in DAC, which will be resolved in dotnet/runtime (calling one of the CLRMD methods ends up with AV while it should not). Since there is nothing actionable on BDN side, I am going to close it. Thank you!

@ezhevita
Copy link

ezhevita commented Dec 5, 2022

@adamsitnik hello and sorry for bothering – could you please link an upstream runtime issue to track? Thanks!

@adamsitnik
Copy link
Member

could you please link an upstream runtime issue to track?

@janvorli do you have a link to the DAC issue/PR?

@janvorli
Copy link
Member

@ezhevita, @adamsitnik I've just created a PR with a fix: dotnet/runtime#79824

@janvorli
Copy link
Member

Actually, I need to do it differently. In the code review, I was reminded why we don't handle hardware exceptions in the mscordac core - it doesn't always work. But there is a different way that we can use and I am going to make such fix.

@janvorli
Copy link
Member

The different fix was just merged in dotnet/runtime#79846

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants