Skip to content
This repository has been archived by the owner on Oct 5, 2024. It is now read-only.

User admin is confusing and inaccurate #328

Open
plusk opened this issue Mar 5, 2018 · 1 comment
Open

User admin is confusing and inaccurate #328

plusk opened this issue Mar 5, 2018 · 1 comment

Comments

@plusk
Copy link
Member

plusk commented Mar 5, 2018

Having just used the user admin a lot as "tellekorps, or as I will now refer to it, counting corps, the search functionality in user admin is rough. It's inconsistent, it often provides a lot of false positives, and the results jump around in order.
Additionally, the list view itself should be sortable on the various columns. Being able to sort alphabetically is crucial.

@duvholt
Copy link
Member

duvholt commented Mar 6, 2018

Probably just need to tweak Fuse settings a bit to make the search less shit:

threshold: 0.6,
location: 0,
distance: 100,
maxPatternLength: 32,
minMatchCharLength: 1,
keys: ['name'],

I think Fuse respects the initial ordering and only performs filtering by default, but we probably sort by user creation or something silly like that.

react-table seems like a nice solution for sorting, but I'm not sure how well it will work with our custom buttons in the table.

@torjusti torjusti self-assigned this Feb 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants