Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate migrations script config and executeScript method #39

Open
redthor opened this issue May 20, 2018 · 0 comments
Open

deprecate migrations script config and executeScript method #39

redthor opened this issue May 20, 2018 · 0 comments

Comments

@redthor
Copy link
Contributor

redthor commented May 20, 2018

I think that the migrations_script_directory config and the related executeScript(Database $db, $file) method add little value for the extra overhead.

https://github.com/doesntmattr/mongodb-migrations/blob/master/src/AntiMattr/MongoDB/Migrations/Version.php#L261

It would be easy enough for anyone to load the javascript file and run it directly against $db in their own migration if they wanted it.

I would like to make this feature deprecated to be removed in 3.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@redthor