feat(ui/components): Checkbox 추가 #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sukvvon
commented
Aug 22, 2024
Comment on lines
+24
to
+25
| data-accent-color={color ?? 'black'} | ||
| data-border-color={borderColor ?? 'gray700'} |
There was a problem hiding this comment.
- data 속성을 통해 사용자가 색상 관련 속성을 알 수 있게 합니다.
- default 색상은 color는 black, borderColor는 gray700입니다.
Comment on lines
+19
to
+20
| const { className, color, borderColor, size, ...restProps } = | ||
| extractMarginProps(props); |
There was a problem hiding this comment.
Checkbox 컴포넌트는
- margin에 대한 모든 속성을 가집니다.
- borderColor, 즉 border 색상, color 즉 Checkbox 내부 색상을 가집니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 번호
작업한 목록을 작성해 주세요
스크린샷
pr 포인트나 궁금한 점을 작성해 주세요