diff --git a/.changeset/purple-hats-decide.md b/.changeset/purple-hats-decide.md new file mode 100644 index 00000000..86fb0d72 --- /dev/null +++ b/.changeset/purple-hats-decide.md @@ -0,0 +1,32 @@ +--- +'@difizen/libro-cofine-editor': patch +'@difizen/libro-code-editor': patch +'@difizen/libro-jupyter': patch +'@difizen/libro-core': patch +'@difizen/libro-lab': patch +'@difizen/libro-docs': patch +'@difizen/libro-code-cell': patch +'@difizen/libro-codemirror': patch +'@difizen/libro-cofine-editor-contribution': patch +'@difizen/libro-cofine-editor-core': patch +'@difizen/libro-cofine-textmate': patch +'@difizen/libro-common': patch +'@difizen/libro-kernel': patch +'@difizen/libro-l10n': patch +'@difizen/libro-lsp': patch +'@difizen/libro-markdown': patch +'@difizen/libro-markdown-cell': patch +'@difizen/libro-output': patch +'@difizen/libro-prompt-cell': patch +'@difizen/libro-raw-cell': patch +'@difizen/libro-rendermime': patch +'@difizen/libro-search': patch +'@difizen/libro-search-code-cell': patch +'@difizen/libro-shared-model': patch +'@difizen/libro-terminal': patch +'@difizen/libro-toc': patch +'@difizen/libro-virtualized': patch +'@difizen/libro-widget': patch +--- + +1. fix the editor in CodeEditorView is undefined diff --git a/packages/libro-code-editor/src/code-editor-view.tsx b/packages/libro-code-editor/src/code-editor-view.tsx index 9c0f5a1b..bed35385 100644 --- a/packages/libro-code-editor/src/code-editor-view.tsx +++ b/packages/libro-code-editor/src/code-editor-view.tsx @@ -148,8 +148,6 @@ export class CodeEditorView extends BaseView { }; override onViewUnmount = () => { - this.editor.dispose(); - if (this.editor.dispose) { this.editor.dispose(); }